Avoid substring allocation in StringUtils.replace

Closes gh-24023

Author: jhoeller

spring-core/src/main/java/org/springframework/util/StringUtils.java

@@ -399,14 +399,14 @@ public static String replace(String inString, String oldPattern, String newPatte
 		int pos = 0;  // our position in the old string
 		int patLen = oldPattern.length();
 		while (index >= 0) {
-			sb.append(inString.substring(pos, index));
+			sb.append(inString, pos, index);
 			sb.append(newPattern);
 			pos = index + patLen;
 			index = inString.indexOf(oldPattern, pos);
 		}
 
 		// append any characters to the right of a match
-		sb.append(inString.substring(pos));
+		sb.append(inString, pos, inString.length());
 		return sb.toString();
 	}