Fix a regression in Jackson builder module registration

This commit brings back the support for registration of multiple
Jackson modules with a null typeId.

Closes gh-22764

Author: sdeleuze

spring-web/src/main/java/org/springframework/http/converter/json/Jackson2ObjectMapperBuilder.java

@@ -56,6 +56,8 @@
 import org.springframework.context.ApplicationContext;
 import org.springframework.util.Assert;
 import org.springframework.util.ClassUtils;
+import org.springframework.util.LinkedMultiValueMap;
+import org.springframework.util.MultiValueMap;
 import org.springframework.util.StreamUtils;
 import org.springframework.util.StringUtils;
 
@@ -599,11 +601,10 @@ public <T extends ObjectMapper> T build() {
 	public void configure(ObjectMapper objectMapper) {
 		Assert.notNull(objectMapper, "ObjectMapper must not be null");
 
-		Map<Object, Module> modulesToRegister = new LinkedHashMap<Object, Module>();
+		MultiValueMap<Object, Module> modulesToRegister = new LinkedMultiValueMap<Object, Module>();
 		if (this.findModulesViaServiceLoader) {
-			// Jackson 2.2+
 			for (Module module : ObjectMapper.findModules(this.moduleClassLoader)) {
-				modulesToRegister.put(module.getTypeId(), module);
+				registerModule(module, modulesToRegister);
 			}
 		}
 		else if (this.findWellKnownModules) {
@@ -612,18 +613,19 @@ else if (this.findWellKnownModules) {
 
 		if (this.modules != null) {
 			for (Module module : this.modules) {
-				modulesToRegister.put(module.getTypeId(), module);
+				registerModule(module, modulesToRegister);
 			}
 		}
 		if (this.moduleClasses != null) {
 			for (Class<? extends Module> moduleClass : this.moduleClasses) {
-				Module module = BeanUtils.instantiateClass(moduleClass);
-				modulesToRegister.put(module.getTypeId(), module);
+				registerModule(BeanUtils.instantiateClass(moduleClass), modulesToRegister);
 			}
 		}
 		// Using Jackson 2.0+ registerModule method, not Jackson 2.2+ registerModules
-		for (Module module : modulesToRegister.values()) {
-			objectMapper.registerModule(module);
+		for (List<Module> nestedModules : modulesToRegister.values()) {
+			for (Module module : nestedModules) {
+				objectMapper.registerModule(module);
+			}
 		}
 
 		if (this.dateFormat != null) {
@@ -678,6 +680,15 @@ else if (this.applicationContext != null) {
 		}
 	}
 
+	private void registerModule(Module module, MultiValueMap<Object, Module> modulesToRegister) {
+		if (module.getTypeId() == null) {
+			modulesToRegister.add(SimpleModule.class.getName(), module);
+		}
+		else {
+			modulesToRegister.set(module.getTypeId(), module);
+		}
+	}
+
 
 	// Any change to this method should be also applied to spring-jms and spring-messaging
 	// MappingJackson2MessageConverter default constructors
@@ -726,14 +737,14 @@ else if (feature instanceof MapperFeature) {
 	}
 
 	@SuppressWarnings("unchecked")
-	private void registerWellKnownModulesIfAvailable(Map<Object, Module> modulesToRegister) {
+	private void registerWellKnownModulesIfAvailable(MultiValueMap<Object, Module> modulesToRegister) {
 		// Java 7 java.nio.file.Path class present?
 		if (ClassUtils.isPresent("java.nio.file.Path", this.moduleClassLoader)) {
 			try {
 				Class<? extends Module> jdk7ModuleClass = (Class<? extends Module>)
 						ClassUtils.forName("com.fasterxml.jackson.datatype.jdk7.Jdk7Module", this.moduleClassLoader);
 				Module jdk7Module = BeanUtils.instantiateClass(jdk7ModuleClass);
-				modulesToRegister.put(jdk7Module.getTypeId(), jdk7Module);
+				modulesToRegister.set(jdk7Module.getTypeId(), jdk7Module);
 			}
 			catch (ClassNotFoundException ex) {
 				// jackson-datatype-jdk7 not available
@@ -746,7 +757,7 @@ private void registerWellKnownModulesIfAvailable(Map<Object, Module> modulesToRe
 				Class<? extends Module> jdk8ModuleClass = (Class<? extends Module>)
 						ClassUtils.forName("com.fasterxml.jackson.datatype.jdk8.Jdk8Module", this.moduleClassLoader);
 				Module jdk8Module = BeanUtils.instantiateClass(jdk8ModuleClass);
-				modulesToRegister.put(jdk8Module.getTypeId(), jdk8Module);
+				modulesToRegister.set(jdk8Module.getTypeId(), jdk8Module);
 			}
 			catch (ClassNotFoundException ex) {
 				// jackson-datatype-jdk8 not available
@@ -759,7 +770,7 @@ private void registerWellKnownModulesIfAvailable(Map<Object, Module> modulesToRe
 				Class<? extends Module> javaTimeModuleClass = (Class<? extends Module>)
 						ClassUtils.forName("com.fasterxml.jackson.datatype.jsr310.JavaTimeModule", this.moduleClassLoader);
 				Module javaTimeModule = BeanUtils.instantiateClass(javaTimeModuleClass);
-				modulesToRegister.put(javaTimeModule.getTypeId(), javaTimeModule);
+				modulesToRegister.set(javaTimeModule.getTypeId(), javaTimeModule);
 			}
 			catch (ClassNotFoundException ex) {
 				// jackson-datatype-jsr310 not available
@@ -772,7 +783,7 @@ private void registerWellKnownModulesIfAvailable(Map<Object, Module> modulesToRe
 				Class<? extends Module> jodaModuleClass = (Class<? extends Module>)
 						ClassUtils.forName("com.fasterxml.jackson.datatype.joda.JodaModule", this.moduleClassLoader);
 				Module jodaModule = BeanUtils.instantiateClass(jodaModuleClass);
-				modulesToRegister.put(jodaModule.getTypeId(), jodaModule);
+				modulesToRegister.set(jodaModule.getTypeId(), jodaModule);
 			}
 			catch (ClassNotFoundException ex) {
 				// jackson-datatype-joda not available
@@ -785,7 +796,7 @@ private void registerWellKnownModulesIfAvailable(Map<Object, Module> modulesToRe
 				Class<? extends Module> kotlinModuleClass = (Class<? extends Module>)
 						ClassUtils.forName("com.fasterxml.jackson.module.kotlin.KotlinModule", this.moduleClassLoader);
 				Module kotlinModule = BeanUtils.instantiateClass(kotlinModuleClass);
-				modulesToRegister.put(kotlinModule.getTypeId(), kotlinModule);
+				modulesToRegister.set(kotlinModule.getTypeId(), kotlinModule);
 			}
 			catch (ClassNotFoundException ex) {
 				// jackson-module-kotlin not available

spring-web/src/test/java/org/springframework/http/converter/json/Jackson2ObjectMapperBuilderTests.java

@@ -33,6 +33,7 @@
 import java.util.Map;
 import java.util.Optional;
 import java.util.TimeZone;
+import java.util.stream.StreamSupport;
 
 import com.fasterxml.jackson.annotation.JsonFilter;
 import com.fasterxml.jackson.annotation.JsonInclude;
@@ -309,6 +310,24 @@ public void overrideWellKnownModuleWithModule() throws IOException {
 		assertNotNull(demoPojo.getOffsetDateTime());
 	}
 
+	@Test  // gh-22740
+	public void registerMultipleModulesWithNullTypeId() {
+		Jackson2ObjectMapperBuilder builder = new Jackson2ObjectMapperBuilder();
+		SimpleModule fooModule = new SimpleModule();
+		fooModule.addSerializer(new FooSerializer());
+		SimpleModule barModule = new SimpleModule();
+		barModule.addSerializer(new BarSerializer());
+		builder.modulesToInstall(fooModule, barModule);
+		ObjectMapper objectMapper = builder.build();
+		assertEquals(1, StreamSupport
+				.stream(getSerializerFactoryConfig(objectMapper).serializers().spliterator(), false)
+				.filter(s -> s.findSerializer(null, SimpleType.construct(Foo.class), null) != null)
+				.count());
+		assertEquals(1, StreamSupport
+				.stream(getSerializerFactoryConfig(objectMapper).serializers().spliterator(), false)
+				.filter(s -> s.findSerializer(null, SimpleType.construct(Bar.class), null) != null)
+				.count());
+	}
 
 	private static SerializerFactoryConfig getSerializerFactoryConfig(ObjectMapper objectMapper) {
 		return ((BasicSerializerFactory) objectMapper.getSerializerFactory()).getFactoryConfig();
@@ -606,4 +625,29 @@ public void setOffsetDateTime(OffsetDateTime offsetDateTime) {
 
 	}
 
+	static class Foo {}
+
+	static class Bar {}
+
+	static class FooSerializer extends JsonSerializer<Foo> {
+		@Override
+		public void serialize(Foo value, JsonGenerator gen, SerializerProvider serializers) throws IOException {
+		}
+
+		@Override
+		public Class<Foo> handledType() {
+			return Foo.class;
+		}
+	}
+
+	static class BarSerializer extends JsonSerializer<Bar> {
+		@Override
+		public void serialize(Bar value, JsonGenerator gen, SerializerProvider serializers) throws IOException {
+		}
+		@Override
+		public Class<Bar> handledType() {
+			return Bar.class;
+		}
+	}
+
 }