Avoid potential integer overflow in seconds->millis transformation

jhoeller · jhoeller · commit f7440884c96b · 2020-08-27T15:32:54.000+02:00
Closes gh-25613
diff --git a/spring-context/src/main/java/org/springframework/context/support/AbstractResourceBasedMessageSource.java b/spring-context/src/main/java/org/springframework/context/support/AbstractResourceBasedMessageSource.java
@@ -178,7 +178,7 @@ protected boolean isFallbackToSystemLocale() {
 	 * a non-classpath location.
 	 */
 	public void setCacheSeconds(int cacheSeconds) {
-		this.cacheMillis = (cacheSeconds * 1000);
+		this.cacheMillis = cacheSeconds * 1000L;
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ protected boolean isFallbackToSystemLocale() {`
`178`	`178`	`* a non-classpath location.`
`179`	`179`	`*/`
`180`	`180`	`public void setCacheSeconds(int cacheSeconds) {`
`181`		`- this.cacheMillis = (cacheSeconds * 1000);`
	`181`	`+ this.cacheMillis = cacheSeconds * 1000L;`
`182`	`182`	`}`
`183`	`183`
`184`	`184`	`/**`