Close-suppressing Connection proxy exposes target isClosed() state

jhoeller · jhoeller · commit f92910941540 · 2020-04-03T22:00:47.000+02:00
Closes gh-24853
diff --git a/spring-jdbc/src/main/java/org/springframework/jdbc/datasource/SingleConnectionDataSource.java b/spring-jdbc/src/main/java/org/springframework/jdbc/datasource/SingleConnectionDataSource.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -316,7 +316,7 @@ else if (method.getName().equals("close")) {
 				return null;
 			}
 			else if (method.getName().equals("isClosed")) {
-				return false;
+				return this.target.isClosed();
 			}
 			else if (method.getName().equals("getTargetConnection")) {
 				// Handle getTargetConnection method: return underlying Connection.

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`/*`
`2`		`- * Copyright 2002-2017 the original author or authors.`
	`2`	`+ * Copyright 2002-2020 the original author or authors.`
`3`	`3`	`*`
`4`	`4`	`* Licensed under the Apache License, Version 2.0 (the "License");`
`5`	`5`	`* you may not use this file except in compliance with the License.`
`@@ -316,7 +316,7 @@ else if (method.getName().equals("close")) {`
`316`	`316`	`return null;`
`317`	`317`	`}`
`318`	`318`	`else if (method.getName().equals("isClosed")) {`
`319`		`- return false;`
	`319`	`+ return this.target.isClosed();`
`320`	`320`	`}`
`321`	`321`	`else if (method.getName().equals("getTargetConnection")) {`
`322`	`322`	`// Handle getTargetConnection method: return underlying Connection.`