Scoped Proxy does not consider "defaultCandidate"

[hosea]

I defined three Services in my configuration:

@Bean(value = "legacyContentService", defaultCandidate = false)
@Scope(value = BeanDefinition.SCOPE_SINGLETON, proxyMode = ScopedProxyMode.INTERFACES)
public ContentService legacyContentService() {
 ....
}

@Bean(value = "contentService", defaultCandidate = false)
@Scope(value = BeanDefinition.SCOPE_SINGLETON, proxyMode = ScopedProxyMode.INTERFACES)
public ContentService contentService() {
  ....		
}

@Bean(value = "contentServiceDispatcher")
@Scope(value = BeanDefinition.SCOPE_SINGLETON, proxyMode = ScopedProxyMode.INTERFACES)
public ContentService contentServiceDispatcher(@Qualifier("legacyContentService") final ContentService legacyContentService, @Qualifier("contentService") ContentService contentService)  {
   return new ContentServiceDispatcher(legacyContentService, contentService);
}

But this lead to an unexpected exception: "no qualifiing bean of type ...ContentSerivce", "expected single matching bean but found 3". So "defaultCandidate = false" does not apply.
Then I removed "proxyMode = ScopeProxyMode.INTERFACES" from the @Scope-Annotations and then it worked. So I took a look at the Creation of the BeanDefinition of scoped beans.

I found, that ScopedProxyUtils#createScopedProxy does not consider the property "defaultCandidate". This property should also be applied to the scoped proxy bean definition.

Found in Spring-aop 6.2.x

I added a PR as proposal: #35627

[jhoeller]

Well spotted, let's fix this for 6.2.12 still (to be released Thursday morning).

As for the proposed fix, I'd rather keep defaultCandidate as an AbstractBeanDefinition-level feature, just like qualifier support. We can put the setDefaultCandidate call next to the copyQualifiersFrom call within the existing AbstractBeanDefinition downcast.

Would you prefer to update your PR along those lines today, force-pushing it? Otherwise, I'm happy to derive a corresponding commit from the PR as it is.

[hosea]

Hi @jhoeller ,

thank you for your feedback. I adjusted my PR to keep defaultCandidate on AbstractBeanDefinition-level.

Kind regards
Hans

[jhoeller]

Superseded by PR #35627.