-
Notifications
You must be signed in to change notification settings - Fork 38.8k
Closed as not planned
Closed as not planned
Copy link
Labels
in: webIssues in web modules (web, webmvc, webflux, websocket)Issues in web modules (web, webmvc, webflux, websocket)status: supersededAn issue that has been superseded by anotherAn issue that has been superseded by anothertype: enhancementA general enhancementA general enhancement
Description
I observed that UriComponentsBuilder#query unexpectedly clears all existing query parameters, when passing "null" as argument. In this case the method behaves like UriComponentsBuilder#replaceQuery that clearly should clear all query parameters when "null" is passed.
The semantic of UriComponentsBuilder#query is unclear: intentionally this method is build for adding query parameters, not for clearing / removing. But it can also be used for clearing all parameters as UriComponentsBuilder#replaceQuery when passing "null".
The path inside the method that executes "queryParams.clear()" should be a noop in my opinion.
PR added as proposal: #35629
Metadata
Metadata
Assignees
Labels
in: webIssues in web modules (web, webmvc, webflux, websocket)Issues in web modules (web, webmvc, webflux, websocket)status: supersededAn issue that has been superseded by anotherAn issue that has been superseded by anothertype: enhancementA general enhancementA general enhancement