From 9a7d01c4f7b09e7cb3fda9e87b9529844db11a0d Mon Sep 17 00:00:00 2001
From: Mengqi Xu <2663479778@qq.com>
Date: Wed, 15 Jan 2025 23:13:53 +0800
Subject: [PATCH] Refactor: Use HttpStatus.Series instead of magic value.

Signed-off-by: Mengqi Xu <2663479778@qq.com>
---
 .../http/DefaultHttpStatusCode.java           | 25 ++++++++++++-------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/spring-web/src/main/java/org/springframework/http/DefaultHttpStatusCode.java b/spring-web/src/main/java/org/springframework/http/DefaultHttpStatusCode.java
index d6e66e395b7b..5857a5a1aff8 100644
--- a/spring-web/src/main/java/org/springframework/http/DefaultHttpStatusCode.java
+++ b/spring-web/src/main/java/org/springframework/http/DefaultHttpStatusCode.java
@@ -24,6 +24,7 @@
  * Default implementation of {@link HttpStatusCode}.
  *
  * @author Arjen Poutsma
+ * @author Mengqi Xu
  * @since 6.0
  */
 final class DefaultHttpStatusCode implements HttpStatusCode, Comparable<HttpStatusCode>, Serializable {
@@ -32,9 +33,12 @@ final class DefaultHttpStatusCode implements HttpStatusCode, Comparable<HttpStat
 
 	private final int value;
 
+	private final HttpStatus.Series series;
+
 
 	public DefaultHttpStatusCode(int value) {
 		this.value = value;
+		this.series = HttpStatus.Series.resolve(value);
 	}
 
 	@Override
@@ -44,37 +48,40 @@ public int value() {
 
 	@Override
 	public boolean is1xxInformational() {
-		return hundreds() == 1;
+		return series() == HttpStatus.Series.INFORMATIONAL;
 	}
 
 	@Override
 	public boolean is2xxSuccessful() {
-		return hundreds() == 2;
+		return series() == HttpStatus.Series.SUCCESSFUL;
 	}
 
 	@Override
 	public boolean is3xxRedirection() {
-		return hundreds() == 3;
+		return series() == HttpStatus.Series.REDIRECTION;
 	}
 
 	@Override
 	public boolean is4xxClientError() {
-		return hundreds() == 4;
+		return series() == HttpStatus.Series.CLIENT_ERROR;
 	}
 
 	@Override
 	public boolean is5xxServerError() {
-		return hundreds() == 5;
+		return series() == HttpStatus.Series.SERVER_ERROR;
 	}
 
 	@Override
 	public boolean isError() {
-		int hundreds = hundreds();
-		return hundreds == 4 || hundreds == 5;
+		return (is4xxClientError() || is5xxServerError());
 	}
 
-	private int hundreds() {
-		return this.value / 100;
+	/**
+	 * Return the HTTP status series of this status code.
+	 * @see HttpStatus.Series
+	 */
+	private HttpStatus.Series series() {
+		return this.series;
 	}