Skip to content

Commit 43a76c4

Browse files
committed
Polishing
See gh-915
1 parent 3381774 commit 43a76c4

File tree

1 file changed

+17
-13
lines changed

1 file changed

+17
-13
lines changed

spring-graphql/src/main/java/org/springframework/graphql/execution/DefaultExecutionGraphQlService.java

Lines changed: 17 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -87,26 +87,30 @@ public final Mono<ExecutionGraphQlResponse> execute(ExecutionGraphQlRequest requ
8787
if (!this.isDefaultExecutionIdProvider && request.getExecutionId() == null) {
8888
request.configureExecutionInput(RESET_EXECUTION_ID_CONFIGURER);
8989
}
90+
9091
ExecutionInput executionInput = request.toExecutionInput();
91-
ContextSnapshot.captureFrom(contextView).updateContext(executionInput.getGraphQLContext());
92-
ExecutionInput updatedExecutionInput = registerDataLoaders(executionInput);
92+
93+
GraphQLContext graphQLContext = executionInput.getGraphQLContext();
94+
ContextSnapshot.captureFrom(contextView).updateContext(graphQLContext);
95+
96+
ExecutionInput updatedExecutionInput =
97+
(this.hasDataLoaderRegistrations ? registerDataLoaders(executionInput) : executionInput);
98+
9399
return Mono.fromFuture(this.graphQlSource.graphQl().executeAsync(updatedExecutionInput))
94100
.map(result -> new DefaultExecutionGraphQlResponse(updatedExecutionInput, result));
95101
});
96102
}
97103

98104
private ExecutionInput registerDataLoaders(ExecutionInput executionInput) {
99-
if (this.hasDataLoaderRegistrations) {
100-
GraphQLContext graphQLContext = executionInput.getGraphQLContext();
101-
DataLoaderRegistry existingRegistry = executionInput.getDataLoaderRegistry();
102-
if (existingRegistry == DataLoaderDispatcherInstrumentationState.EMPTY_DATALOADER_REGISTRY) {
103-
DataLoaderRegistry newRegistry = DataLoaderRegistry.newRegistry().build();
104-
applyDataLoaderRegistrars(newRegistry, graphQLContext);
105-
executionInput = executionInput.transform(builder -> builder.dataLoaderRegistry(newRegistry));
106-
}
107-
else {
108-
applyDataLoaderRegistrars(existingRegistry, graphQLContext);
109-
}
105+
GraphQLContext graphQLContext = executionInput.getGraphQLContext();
106+
DataLoaderRegistry existingRegistry = executionInput.getDataLoaderRegistry();
107+
if (existingRegistry == DataLoaderDispatcherInstrumentationState.EMPTY_DATALOADER_REGISTRY) {
108+
DataLoaderRegistry newRegistry = DataLoaderRegistry.newRegistry().build();
109+
applyDataLoaderRegistrars(newRegistry, graphQLContext);
110+
executionInput = executionInput.transform(builder -> builder.dataLoaderRegistry(newRegistry));
111+
}
112+
else {
113+
applyDataLoaderRegistrars(existingRegistry, graphQLContext);
110114
}
111115
return executionInput;
112116
}

0 commit comments

Comments
 (0)