Remove session state from onClose only

rstoyanchev · rstoyanchev · commit bb734bf8949b · 2024-03-27T11:50:26.000Z
Doing the same eagerly from onError has the side effect of not being able to delegate handleConnectionClosed to interceptors. Closes gh-872
diff --git a/spring-graphql/src/main/java/org/springframework/graphql/server/webmvc/GraphQlWebSocketHandler.java b/spring-graphql/src/main/java/org/springframework/graphql/server/webmvc/GraphQlWebSocketHandler.java
@@ -326,14 +326,6 @@ private <T> TextMessage encode(GraphQlWebSocketMessage message) {
 		}
 	}
 
-	@Override
-	public void handleTransportError(WebSocketSession session, Throwable exception) {
-		SessionState info = this.sessionInfoMap.remove(session.getId());
-		if (info != null) {
-			info.dispose();
-		}
-	}
-
 	@Override
 	public void afterConnectionClosed(WebSocketSession session, CloseStatus closeStatus) {
 		String id = session.getId();

Original file line number	Diff line number	Diff line change
`@@ -326,14 +326,6 @@ private <T> TextMessage encode(GraphQlWebSocketMessage message) {`
`326`	`326`	`}`
`327`	`327`	`}`
`328`	`328`
`329`		`- @Override`
`330`		`- public void handleTransportError(WebSocketSession session, Throwable exception) {`
`331`		`- SessionState info = this.sessionInfoMap.remove(session.getId());`
`332`		`- if (info != null) {`
`333`		`- info.dispose();`
`334`		`- }`
`335`		`- }`
`336`		`-`
`337`	`329`	`@Override`
`338`	`330`	`public void afterConnectionClosed(WebSocketSession session, CloseStatus closeStatus) {`
`339`	`331`	`String id = session.getId();`