Error while inspecting properties without read method for a type

[desiderati]

Version: Spring GraphQL 1.3.1

Let's suppose you have defined a type called TestObject:

type TestObject {
   id: ID!
   name: String
}

And for some reason, you mistyped the name property or forgot to define a getter method for name, which is private. The Spring GraphQL Framework will generate the following error if property spring.graphql.schema.inspection.enabled: true:

Caused by: java.lang.IllegalArgumentException: Method must not be null
    at org.springframework.util.Assert.notNull(Assert.java:172)
    at org.springframework.core.ResolvableType.forMethodReturnType(ResolvableType.java:1272)
    at org.springframework.graphql.execution.SchemaMappingInspector.checkFieldsContainer(SchemaMappingInspector.java:173)
    at org.springframework.graphql.execution.SchemaMappingInspector.checkField(SchemaMappingInspector.java:235)

And this error does not show much about the problem. It would be nice if we instead of calling:

line: 173 > checkField(fieldContainer, field, ResolvableType.forMethodReturnType(descriptor.getReadMethod()));

We could call a function that translates this IllegalArgumentException into a more friendly error message, like: "Type: TestObject, property: name does not have a reader method defined!"

Thanks guys.

[bclozel]

Can you share a minimal sample please? I cannot reproduce the problem right now.
Here's what I've got:

	@Controller
	class TestObjectController {

		@QueryMapping
		public TestObject testObjectById(@Argument Long id) {
			return new TestObject();
		}
	}

	class TestObject {

		private String name;

	}

And here's the schema inspection report:

GraphQL schema inspection:
	Unmapped fields: {TestObject=[name]}
	Unmapped registrations: {}
	Unmapped arguments: {}
	Skipped types: []

Maybe there's something missing from the picture here?
Can you reproduce the same error against 1.3.4? This might have been fixed with #1037 already.

[spring-projects-issues]

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

[spring-projects-issues]

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

[desiderati]

Sorry guys, I was on vacation last week. Could you reopen? If so, I will show the problem.

[bclozel]

No worries, we're still seeing comments on closed issues. I'll reopen it as soon as you provide a minimal reproducer.