-
Notifications
You must be signed in to change notification settings - Fork 329
Closed
Labels
in: coreIssues related to config and core supportIssues related to config and core supportstatus: backportedAn issue that has been backported to maintenance branchesAn issue that has been backported to maintenance branchestype: bugA general bugA general bug
Milestone
Description
Line 152 in 1032f99
| throw new CompletionException(error); |
This line will unconditionally wrap error in a CompletionException. If the incoming error is already a CompletionException, this leads to confusing double-wrapping. Consider doing what CompletableFuture does and conditionally wrapping:
/**
* Returns the encoding of the given (non-null) exception as a
* wrapped CompletionException unless it is one already.
*/
static AltResult encodeThrowable(Throwable x) {
return new AltResult((x instanceof CompletionException) ? x :
new CompletionException(x));
}
Metadata
Metadata
Assignees
Labels
in: coreIssues related to config and core supportIssues related to config and core supportstatus: backportedAn issue that has been backported to maintenance branchesAn issue that has been backported to maintenance branchestype: bugA general bugA general bug