Skip to content

Commit 747c7b3

Browse files
committed
Check secure sample works
1 parent 11895ff commit 747c7b3

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

samples/grpc-secure/src/main/java/org/springframework/grpc/sample/GrpcServerApplication.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,13 @@
77
import org.springframework.context.annotation.Bean;
88
import org.springframework.grpc.server.GlobalServerInterceptor;
99
import org.springframework.grpc.server.security.GrpcSecurity;
10-
import org.springframework.security.config.annotation.authentication.configuration.EnableGlobalAuthentication;
1110
import org.springframework.security.core.userdetails.User;
1211
import org.springframework.security.provisioning.InMemoryUserDetailsManager;
1312

1413
import io.grpc.Metadata;
1514
import io.grpc.ServerInterceptor;
1615

1716
@SpringBootApplication
18-
@EnableGlobalAuthentication
1917
class GrpcServerApplication {
2018

2119
public static final Metadata.Key<String> USER_KEY = Metadata.Key.of("X-USER", Metadata.ASCII_STRING_MARSHALLER);

samples/grpc-secure/src/test/java/org/springframework/grpc/sample/GrpcServerApplicationTests.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import java.util.concurrent.atomic.AtomicReference;
88

99
import org.awaitility.Awaitility;
10-
import org.junit.jupiter.api.Disabled;
1110
import org.junit.jupiter.api.Test;
1211
import org.springframework.beans.factory.annotation.Autowired;
1312
import org.springframework.beans.factory.annotation.Qualifier;
@@ -55,10 +54,9 @@ void contextLoads() {
5554
}
5655

5756
@Test
58-
@Disabled("Code is coming back PERMISSION_DENIED NOT UNAUTHENTICATED")
5957
void unauthenticated() {
6058
assertThatExceptionOfType(StatusRuntimeException.class)
61-
.isThrownBy(() -> basic.streamHello(HelloRequest.newBuilder().setName("Alien").build()).next())
59+
.isThrownBy(() -> stub.sayHello(HelloRequest.newBuilder().setName("Alien").build()))
6260
.extracting("status.code")
6361
.isEqualTo(Code.UNAUTHENTICATED);
6462
}

samples/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<module>grpc-reactive</module>
2222
<module>grpc-secure</module>
2323
<module>grpc-server</module>
24-
<!-- <module>grpc-server-kotlin</module>-->
24+
<module>grpc-server-kotlin</module>
2525
<module>grpc-server-netty-shaded</module>
2626
<module>grpc-tomcat</module>
2727
<!-- <module>grpc-tomcat-secure</module>-->

0 commit comments

Comments
 (0)