Skip to content

Commit d24e80a

Browse files
author
Dave Syer
committed
Move codec server config to a central location
There was no need for the duplication of netty and shaded netty when the builder is generic anyway.
1 parent 9cf0227 commit d24e80a

File tree

3 files changed

+20
-29
lines changed

3 files changed

+20
-29
lines changed

spring-grpc-spring-boot-autoconfigure/src/main/java/org/springframework/grpc/autoconfigure/server/GrpcServerAutoConfiguration.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,9 @@
3333
import org.springframework.grpc.server.lifecycle.GrpcServerLifecycle;
3434

3535
import io.grpc.BindableService;
36+
import io.grpc.CompressorRegistry;
37+
import io.grpc.DecompressorRegistry;
38+
import io.grpc.ServerBuilder;
3639

3740
/**
3841
* {@link EnableAutoConfiguration Auto-configuration} for gRPC server-side components.
@@ -76,4 +79,17 @@ GrpcServiceDiscoverer grpcServiceDiscoverer(ObjectProvider<BindableService> bind
7679
return new DefaultGrpcServiceDiscoverer(bindableServicesProvider);
7780
}
7881

82+
@ConditionalOnBean(CompressorRegistry.class)
83+
@Bean
84+
<T extends ServerBuilder<T>> ServerBuilderCustomizer<T> compressionServerConfigurer(CompressorRegistry registry) {
85+
return builder -> builder.compressorRegistry(registry);
86+
}
87+
88+
@ConditionalOnBean(DecompressorRegistry.class)
89+
@Bean
90+
<T extends ServerBuilder<T>> ServerBuilderCustomizer<T> decompressionServerConfigurer(
91+
DecompressorRegistry registry) {
92+
return builder -> builder.decompressorRegistry(registry);
93+
}
94+
7995
}

spring-grpc-spring-boot-autoconfigure/src/main/java/org/springframework/grpc/autoconfigure/server/GrpcServerFactoryAutoConfiguration.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@
1919
import java.util.stream.Collectors;
2020

2121
import io.grpc.BindableService;
22+
import io.grpc.CompressorRegistry;
23+
import io.grpc.DecompressorRegistry;
24+
import io.grpc.ServerBuilder;
2225
import io.grpc.servlet.jakarta.GrpcServlet;
2326
import io.grpc.servlet.jakarta.ServletServerBuilder;
2427

@@ -35,6 +38,7 @@
3538
import org.springframework.context.annotation.Configuration;
3639
import org.springframework.context.annotation.Import;
3740
import org.springframework.core.Ordered;
41+
import org.springframework.grpc.server.ServerBuilderCustomizer;
3842
import org.springframework.util.unit.DataSize;
3943

4044
/**

spring-grpc-spring-boot-autoconfigure/src/main/java/org/springframework/grpc/autoconfigure/server/GrpcServerFactoryConfigurations.java

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020

2121
import javax.net.ssl.KeyManagerFactory;
2222

23-
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
2423
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2524
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
2625
import org.springframework.boot.context.properties.EnableConfigurationProperties;
@@ -34,8 +33,6 @@
3433
import org.springframework.grpc.server.ServerBuilderCustomizer;
3534
import org.springframework.grpc.server.ShadedNettyGrpcServerFactory;
3635

37-
import io.grpc.CompressorRegistry;
38-
import io.grpc.DecompressorRegistry;
3936
import io.grpc.netty.NettyServerBuilder;
4037

4138
/**
@@ -69,20 +66,6 @@ ShadedNettyGrpcServerFactory shadedNettyGrpcServerFactory(GrpcServerProperties p
6966
return factory;
7067
}
7168

72-
@ConditionalOnBean(CompressorRegistry.class)
73-
@Bean
74-
ServerBuilderCustomizer<io.grpc.netty.shaded.io.grpc.netty.NettyServerBuilder> compressionServerConfigurer(
75-
CompressorRegistry registry) {
76-
return builder -> builder.compressorRegistry(registry);
77-
}
78-
79-
@ConditionalOnBean(DecompressorRegistry.class)
80-
@Bean
81-
ServerBuilderCustomizer<io.grpc.netty.shaded.io.grpc.netty.NettyServerBuilder> decompressionServerConfigurer(
82-
DecompressorRegistry registry) {
83-
return builder -> builder.decompressorRegistry(registry);
84-
}
85-
8669
}
8770

8871
@Configuration(proxyBeanMethods = false)
@@ -109,18 +92,6 @@ NettyGrpcServerFactory nettyGrpcServerFactory(GrpcServerProperties properties,
10992
return factory;
11093
}
11194

112-
@ConditionalOnBean(CompressorRegistry.class)
113-
@Bean
114-
ServerBuilderCustomizer<NettyServerBuilder> compressionServerConfigurer(CompressorRegistry registry) {
115-
return builder -> builder.compressorRegistry(registry);
116-
}
117-
118-
@ConditionalOnBean(DecompressorRegistry.class)
119-
@Bean
120-
ServerBuilderCustomizer<NettyServerBuilder> decompressionServerConfigurer(DecompressorRegistry registry) {
121-
return builder -> builder.decompressorRegistry(registry);
122-
}
123-
12495
}
12596

12697
}

0 commit comments

Comments
 (0)