Skip to content

Commit 5b03db3

Browse files
committed
Upgrade dependencies; prepare for release
* Fix new Sonar smell
1 parent fcca7a7 commit 5b03db3

File tree

2 files changed

+14
-22
lines changed

2 files changed

+14
-22
lines changed

build.gradle

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ ext {
6161
groovyVersion = '2.5.10'
6262
hamcrestVersion = '2.2'
6363
hazelcastVersion = '3.12.6'
64-
hibernateVersion = '5.4.12.Final'
64+
hibernateVersion = '5.4.13.Final'
6565
hsqldbVersion = '2.5.0'
6666
h2Version = '1.4.200'
6767
jacksonVersion = '2.10.3'
@@ -79,7 +79,7 @@ ext {
7979
kryoShadedVersion = '4.0.2'
8080
lettuceVersion = '5.2.2.RELEASE'
8181
log4jVersion = '2.13.1'
82-
micrometerVersion = '1.3.6'
82+
micrometerVersion = '1.3.7'
8383
mockitoVersion = '3.3.3'
8484
mongoDriverVersion = '4.0.1'
8585
mysqlVersion = '8.0.19'
@@ -92,12 +92,12 @@ ext {
9292
servletApiVersion = '4.0.1'
9393
smackVersion = '4.3.4'
9494
springAmqpVersion = project.hasProperty('springAmqpVersion') ? project.springAmqpVersion : '2.2.5.RELEASE'
95-
springDataVersion = project.hasProperty('springDataVersion') ? project.springDataVersion : 'Neumann-M4'
96-
springSecurityVersion = project.hasProperty('springSecurityVersion') ? project.springSecurityVersion : '5.3.0.RELEASE'
95+
springDataVersion = project.hasProperty('springDataVersion') ? project.springDataVersion : 'Neumann-RC1'
96+
springSecurityVersion = project.hasProperty('springSecurityVersion') ? project.springSecurityVersion : '5.3.1.RELEASE'
9797
springRetryVersion = '1.2.5.RELEASE'
9898
springVersion = project.hasProperty('springVersion') ? project.springVersion : '5.2.5.RELEASE'
9999
springWsVersion = '3.0.8.RELEASE'
100-
tomcatVersion = "9.0.31"
100+
tomcatVersion = "9.0.33"
101101
xstreamVersion = '1.4.11.1'
102102

103103
javaProjects = subprojects - project(':spring-integration-bom')
@@ -317,7 +317,7 @@ configure(javaProjects) { subproject ->
317317

318318
checkstyle {
319319
configFile = file("$rootDir/src/checkstyle/checkstyle.xml")
320-
toolVersion = project.hasProperty('checkstyleVersion') ? project.checkstyleVersion : '8.30'
320+
toolVersion = project.hasProperty('checkstyleVersion') ? project.checkstyleVersion : '8.31'
321321
}
322322

323323
jar {

spring-integration-file/src/main/java/org/springframework/integration/file/remote/RemoteFileTemplate.java

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -488,19 +488,18 @@ public <T, C> T executeWithClient(ClientCallback<C, T> callback) {
488488
}
489489

490490
private StreamHolder payloadToInputStream(Message<?> message) throws MessageDeliveryException {
491+
Object payload = message.getPayload();
491492
try {
492-
Object payload = message.getPayload();
493-
InputStream dataInputStream = null;
494-
String name = null;
495493
if (payload instanceof File) {
496494
File inputFile = (File) payload;
497495
if (inputFile.exists()) {
498-
dataInputStream = new BufferedInputStream(new FileInputStream(inputFile));
499-
name = inputFile.getAbsolutePath();
496+
return new StreamHolder(
497+
new BufferedInputStream(new FileInputStream(inputFile)), inputFile.getAbsolutePath());
500498
}
501499
}
502500
else if (payload instanceof byte[] || payload instanceof String) {
503501
byte[] bytes;
502+
String name;
504503
if (payload instanceof String) {
505504
bytes = ((String) payload).getBytes(this.charset);
506505
name = "String payload";
@@ -509,34 +508,27 @@ else if (payload instanceof byte[] || payload instanceof String) {
509508
bytes = (byte[]) payload;
510509
name = "byte[] payload";
511510
}
512-
dataInputStream = new ByteArrayInputStream(bytes);
511+
return new StreamHolder(new ByteArrayInputStream(bytes), name);
513512
}
514513
else if (payload instanceof InputStream) {
515-
dataInputStream = (InputStream) payload;
516-
name = "InputStream payload";
514+
return new StreamHolder((InputStream) payload, "InputStream payload");
517515
}
518516
else if (payload instanceof Resource) {
519517
Resource resource = (Resource) payload;
520-
dataInputStream = resource.getInputStream();
521518
String filename = resource.getFilename();
522-
name = filename != null ? filename : "Resource payload";
519+
return new StreamHolder(resource.getInputStream(), filename != null ? filename : "Resource payload");
523520
}
524521
else {
525522
throw new IllegalArgumentException("Unsupported payload type ["
526523
+ payload.getClass().getName()
527524
+ "]. The only supported payloads are " +
528525
"java.io.File, java.lang.String, byte[], and InputStream");
529526
}
530-
if (dataInputStream == null) {
531-
return null;
532-
}
533-
else {
534-
return new StreamHolder(dataInputStream, name);
535-
}
536527
}
537528
catch (Exception e) {
538529
throw new MessageDeliveryException(message, "Failed to create sendable file.", e);
539530
}
531+
return null;
540532
}
541533

542534
private void sendFileToRemoteDirectory(InputStream inputStream, String temporaryRemoteDirectoryArg,

0 commit comments

Comments
 (0)