Fix new Sonar smells

Author: artembilan

spring-integration-core/src/main/java/org/springframework/integration/config/ConsumerEndpointFactoryBean.java

@@ -196,26 +196,7 @@ public void afterPropertiesSet() {
 					"Consider specifying the 'beanName' property on this ConsumerEndpointFactoryBean.");
 		}
 		else {
-			try {
-				if (!this.beanName.startsWith("org.springframework")) {
-					MessageHandler targetHandler = this.handler;
-					if (AopUtils.isAopProxy(targetHandler)) {
-						Object target = ((Advised) targetHandler).getTargetSource().getTarget();
-						if (target instanceof MessageHandler) {
-							targetHandler = (MessageHandler) target;
-						}
-					}
-					if (targetHandler instanceof IntegrationObjectSupport) {
-						((IntegrationObjectSupport) targetHandler).setComponentName(this.beanName);
-					}
-				}
-			}
-			catch (Exception e) {
-				if (LOGGER.isDebugEnabled()) {
-					LOGGER.debug("Could not set component name for handler "
-							+ this.handler + " for " + this.beanName + " :" + e.getMessage());
-				}
-			}
+			populateComponentNameIfAny();
 		}
 
 		if (!(this.handler instanceof ReactiveMessageHandlerAdapter)) {
@@ -230,6 +211,29 @@ else if (!CollectionUtils.isEmpty(this.adviceChain)) {
 		initializeEndpoint();
 	}
 
+	private void populateComponentNameIfAny() {
+		try {
+			if (!this.beanName.startsWith("org.springframework")) {
+				MessageHandler targetHandler = this.handler;
+				if (AopUtils.isAopProxy(targetHandler)) {
+					Object target = ((Advised) targetHandler).getTargetSource().getTarget();
+					if (target instanceof MessageHandler) {
+						targetHandler = (MessageHandler) target;
+					}
+				}
+				if (targetHandler instanceof IntegrationObjectSupport) {
+					((IntegrationObjectSupport) targetHandler).setComponentName(this.beanName);
+				}
+			}
+		}
+		catch (Exception e) {
+			if (LOGGER.isDebugEnabled()) {
+				LOGGER.debug("Could not set component name for handler "
+						+ this.handler + " for " + this.beanName + " :" + e.getMessage());
+			}
+		}
+	}
+
 	private void adviceChain() {
 		if (!CollectionUtils.isEmpty(this.adviceChain)) {
 			/*

spring-integration-mongodb/src/main/java/org/springframework/integration/mongodb/outbound/ReactiveMongoDbStoringMessageHandler.java

@@ -105,9 +105,9 @@ protected void onInit() {
 		super.onInit();
 		this.evaluationContext = ExpressionUtils.createStandardEvaluationContext(getBeanFactory());
 		if (this.mongoTemplate == null) {
-			ReactiveMongoTemplate mongoTemplate = new ReactiveMongoTemplate(this.mongoDbFactory, this.mongoConverter);
-			mongoTemplate.setApplicationContext(getApplicationContext());
-			this.mongoTemplate = mongoTemplate;
+			ReactiveMongoTemplate template = new ReactiveMongoTemplate(this.mongoDbFactory, this.mongoConverter);
+			template.setApplicationContext(getApplicationContext());
+			this.mongoTemplate = template;
 		}
 		this.initialized = true;
 	}