GH-3256: Fix interaction with delayed listener reg

- Use the test listener before waiting for delayed listener registration.
- Don't wait for delayed listener registration if the test fails.

Author: garyrussell

spring-integration-ip/src/main/java/org/springframework/integration/ip/tcp/connection/AbstractClientConnectionFactory.java

@@ -183,6 +183,7 @@ private TcpConnectionSupport doObtain(boolean singleUse) {
 
 		connection = buildNewConnection();
 		if (this.connectionTest != null && !this.connectionTest.test(connection)) {
+			connection.setTestFailed(true);
 			connection.close();
 			throw new UncheckedIOException(new IOException("Connection test failed for " + connection));
 		}

spring-integration-ip/src/main/java/org/springframework/integration/ip/tcp/connection/TcpConnectionSupport.java

@@ -101,6 +101,8 @@ public abstract class TcpConnectionSupport implements TcpConnection {
 	 */
 	private boolean needsTest;
 
+	private volatile boolean testFailed;
+
 	public TcpConnectionSupport() {
 		this(null);
 	}
@@ -151,6 +153,10 @@ public TcpConnectionSupport(Socket socket, boolean server, boolean lookupHost,
 		}
 	}
 
+	void setTestFailed(boolean testFailed) {
+		this.testFailed = testFailed;
+	}
+
 	/**
 	 * Closes this connection.
 	 */
@@ -305,16 +311,16 @@ public void registerSender(@Nullable TcpSender sender) {
 	 */
 	@Override
 	public TcpListener getListener() {
-		if (this.manualListenerRegistration) {
+		if (this.needsTest && this.testListener != null) {
+			this.needsTest = false;
+			return this.testListener;
+		}
+		if (this.manualListenerRegistration && !this.testFailed) {
 			if (this.logger.isDebugEnabled()) {
 				this.logger.debug(getConnectionId() + " Waiting for listener registration");
 			}
 			waitForListenerRegistration();
 		}
-		if (this.needsTest && this.testListener != null) {
-			this.needsTest = false;
-			return this.testListener;
-		}
 		return this.listener;
 	}