GH-3241: Fix Sonar issue

garyrussell · garyrussell · commit cc0c2fd2fee5 · 2020-04-07T10:32:01.000-04:00
diff --git a/spring-integration-core/src/main/java/org/springframework/integration/selector/MetadataStoreSelector.java b/spring-integration-core/src/main/java/org/springframework/integration/selector/MetadataStoreSelector.java
@@ -123,7 +123,7 @@ public boolean accept(Message<?> message) {
 				if (oldValue == null) {
 					return this.metadataStore.putIfAbsent(key, value) == null;
 				}
-				if (this.compareValues.test(oldValue, value)) {
+				if (this.compareValues.test(oldValue, value)) { // NOSONAR (null dereference)
 					return this.metadataStore.replace(key, oldValue, value);
 				}
 				return false;

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ public boolean accept(Message<?> message) {`
`123`	`123`	`if (oldValue == null) {`
`124`	`124`	`return this.metadataStore.putIfAbsent(key, value) == null;`
`125`	`125`	`}`
`126`		`- if (this.compareValues.test(oldValue, value)) {`
	`126`	`+ if (this.compareValues.test(oldValue, value)) { // NOSONAR (null dereference)`
`127`	`127`	`return this.metadataStore.replace(key, oldValue, value);`
`128`	`128`	`}`
`129`	`129`	`return false;`