RedisLockRegistry stopRenew not thread safe #10446

PiotrDuz · web-flow · commit cd73bd8ac37f · 2025-10-19T20:38:12.000+02:00
Closes #10446 + remove dunnecassary comment Signed-off-by: PiotrDuz <39244523+PiotrDuz@users.noreply.github.com>
diff --git a/spring-integration-redis/src/main/java/org/springframework/integration/redis/util/RedisLockRegistry.java b/spring-integration-redis/src/main/java/org/springframework/integration/redis/util/RedisLockRegistry.java
@@ -600,7 +600,6 @@ protected final boolean renew(long expireAfter) {
 			return res;
 		}
 
-		/* This method can be called by more than 1 thread, thus we need to make sure that it is safe*/
 		protected final void stopRenew() {
 			ScheduledFuture<?> renewFutureToCancel = this.renewFuture;
 			if (renewFutureToCancel != null) {

Original file line number	Diff line number	Diff line change
`@@ -600,7 +600,6 @@ protected final boolean renew(long expireAfter) {`
`600`	`600`	`return res;`
`601`	`601`	`}`
`602`	`602`
`603`		`- /* This method can be called by more than 1 thread, thus we need to make sure that it is safe*/`
`604`	`603`	`protected final void stopRenew() {`
`605`	`604`	`ScheduledFuture<?> renewFutureToCancel = this.renewFuture;`
`606`	`605`	`if (renewFutureToCancel != null) {`