Skip to content

Commit e053e2a

Browse files
artembilangaryrussell
authored andcommitted
INT-4524: Fix MailReceivingMessageSource BF usage
JIRA: https://jira.spring.io/browse/INT-4524
1 parent 8f639ad commit e053e2a

File tree

2 files changed

+0
-51
lines changed

2 files changed

+0
-51
lines changed

spring-integration-file/src/main/java/org/springframework/integration/file/FileReadingMessageSource.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,6 @@
4141
import java.util.concurrent.atomic.AtomicBoolean;
4242
import java.util.regex.Matcher;
4343

44-
import org.apache.commons.logging.Log;
45-
import org.apache.commons.logging.LogFactory;
46-
4744
import org.springframework.context.Lifecycle;
4845
import org.springframework.integration.aggregator.ResequencingMessageGroupProcessor;
4946
import org.springframework.integration.core.MessageSource;
@@ -89,8 +86,6 @@ public class FileReadingMessageSource extends AbstractMessageSource<File>
8986

9087
private static final int DEFAULT_INTERNAL_QUEUE_CAPACITY = 5;
9188

92-
private static final Log logger = LogFactory.getLog(FileReadingMessageSource.class);
93-
9489
private final AtomicBoolean running = new AtomicBoolean();
9590

9691
/*

spring-integration-mail/src/main/java/org/springframework/integration/mail/MailReceivingMessageSource.java

Lines changed: 0 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,8 @@
2020
import java.util.Queue;
2121
import java.util.concurrent.ConcurrentLinkedQueue;
2222

23-
import org.apache.commons.logging.Log;
24-
import org.apache.commons.logging.LogFactory;
25-
26-
import org.springframework.beans.factory.BeanFactory;
2723
import org.springframework.integration.core.MessageSource;
2824
import org.springframework.integration.endpoint.AbstractMessageSource;
29-
import org.springframework.integration.support.DefaultMessageBuilderFactory;
30-
import org.springframework.integration.support.MessageBuilderFactory;
31-
import org.springframework.integration.support.utils.IntegrationUtils;
3225
import org.springframework.messaging.Message;
3326
import org.springframework.messaging.MessagingException;
3427
import org.springframework.util.Assert;
@@ -46,60 +39,21 @@
4639
*/
4740
public class MailReceivingMessageSource extends AbstractMessageSource<Object> {
4841

49-
private final Log logger = LogFactory.getLog(this.getClass());
50-
5142
private final MailReceiver mailReceiver;
5243

5344
private final Queue<Object> mailQueue = new ConcurrentLinkedQueue<>();
5445

55-
private BeanFactory beanFactory;
56-
57-
private MessageBuilderFactory messageBuilderFactory = new DefaultMessageBuilderFactory();
58-
59-
private boolean messageBuilderFactorySet;
60-
61-
private String beanName;
62-
6346

6447
public MailReceivingMessageSource(MailReceiver mailReceiver) {
6548
Assert.notNull(mailReceiver, "mailReceiver must not be null");
6649
this.mailReceiver = mailReceiver;
6750
}
6851

69-
@Override
70-
public final void setBeanFactory(BeanFactory beanFactory) {
71-
this.beanFactory = beanFactory;
72-
}
73-
74-
protected BeanFactory getBeanFactory() {
75-
return this.beanFactory;
76-
}
77-
78-
protected MessageBuilderFactory getMessageBuilderFactory() {
79-
if (!this.messageBuilderFactorySet) {
80-
if (this.beanFactory != null) {
81-
this.messageBuilderFactory = IntegrationUtils.getMessageBuilderFactory(this.beanFactory);
82-
}
83-
this.messageBuilderFactorySet = true;
84-
}
85-
return this.messageBuilderFactory;
86-
}
87-
88-
@Override
89-
public String getComponentName() {
90-
return this.beanName;
91-
}
92-
9352
@Override
9453
public String getComponentType() {
9554
return "mail:inbound-channel-adapter";
9655
}
9756

98-
@Override
99-
public void setBeanName(String name) {
100-
this.beanName = name;
101-
}
102-
10357
@Override
10458
protected Object doReceive() {
10559
try {

0 commit comments

Comments
 (0)