Skip to content

RedisLockRegistry stopRenew not thread safe #10446 #10467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 20, 2025
+3 −2
Merged

RedisLockRegistry stopRenew not thread safe #10446 #10467

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
87de896
RedisLockRegistry stopRenew not thread safe #10446
PiotrDuz Oct 6, 2025
a6518c4
Merge branch 'spring-projects:main' into patch-1
PiotrDuz Oct 19, 2025
cd73bd8
RedisLockRegistry stopRenew not thread safe #10446
PiotrDuz Oct 19, 2025
332f245
RedisLockRegistry stopRenew not thread safe #10446
PiotrDuz Oct 19, 2025
b09cabe
Remove Author
PiotrDuz Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...ion-redis/src/main/java/org/springframework/integration/redis/util/RedisLockRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@
* @author Youbin Wu
* @author Michal Domagala
* @author Severin Kistler
* @author PiotrDuz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, only real name can go here.
This part is for the credability: when some one reads our code, they would see who did changes to the class.
When it is nick-name like this there is not too much to acknowledge the person.
Therefore, if you don't want to share your real name, then you might not interested in the credit, thus no need in this @author in the class.

Thanks for understanding!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, this has been changes. No worries ;)

*
* @since 4.0
*
Expand Down Expand Up @@ -601,8 +602,9 @@ protected final boolean renew(long expireAfter) {
}

protected final void stopRenew() {
if (this.renewFuture != null) {
this.renewFuture.cancel(true);
ScheduledFuture<?> renewFutureToCancel = this.renewFuture;
if (renewFutureToCancel != null) {
renewFutureToCancel.cancel(true);
this.renewFuture = null;
}
}
Expand Down