upgrade jcifs version from 2.1.40 to 3.0.0 #10534
Conversation
closes spring-projects#10533 Signed-off-by: Daniel Frey <[email protected]>
There was a problem hiding this comment.
Apparently this new version was published just after our RC 😂: https://central.sonatype.com/artifact/org.codelibs/jcifs
this is great catch , Dan!
please, consider to revise our SMB doc to be sure that we mention proper packages.
Also, what’s-new chapter deserves a section for such an SMB module change.
After merging this next week for (surprise!) RC2, we also would need to mention package change in the migration guide. Not you already: just a reminder for myself and the team.
thank you for another great contribution , Dan!
cppwfs
added
in: smb
type: dependency-upgrade
|
@artembilan I updated the |
There was a problem hiding this comment.
This is good, Dan.
Thank you!
I’ll merge tomorrow with some minor clean up.
Which is:
- One sentence per line in docs
- Just
SMB Changesfor the title is enough. pay attention that every word (but articles and conjunctions) in the title has to be capitalized - The commit message has to be comprehensive and thing by itself. I mean I’ll put your description from issue and PR into the final commit message. It is not always possible to follow the link from commit history.
3 participants
This PR upgrades the jcifs library from 2.1.40 to 3.0.0, which supports modern Samba server connections, athentication, etc, while retains backwards compatibility with SMB1 (which, is mostly no longer supported by Windows).
closes #10533