PR review

Signed-off-by: Soby Chacko <[email protected]>

Author: sobychacko

spring-kafka/src/main/java/org/springframework/kafka/core/DefaultShareConsumerFactory.java

@@ -261,7 +261,6 @@ public void addListener(Listener<K, V> listener) {
 	 * </p>
 	 * @param index the index (list position).
 	 * @param listener the listener to add.
-	 * @since 2.5
 	 */
 	@Override
 	public void addListener(int index, Listener<K, V> listener) {

spring-kafka/src/test/java/org/springframework/kafka/core/DefaultShareConsumerFactoryTests.java

@@ -36,11 +36,8 @@
 import org.apache.kafka.common.serialization.StringSerializer;
 import org.junit.jupiter.api.Test;
 
-import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.kafka.test.EmbeddedKafkaBroker;
 import org.springframework.kafka.test.context.EmbeddedKafka;
-import org.springframework.test.annotation.DirtiesContext;
-import org.springframework.test.context.junit.jupiter.SpringJUnitConfig;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
@@ -59,13 +56,8 @@
 				"share.coordinator.state.topic.replication.factor=1",
 				"share.coordinator.state.topic.min.isr=1"
 		})
-@SpringJUnitConfig
-@DirtiesContext
 class DefaultShareConsumerFactoryTests {
 
-	@Autowired
-	private EmbeddedKafkaBroker embeddedKafka;
-
 	@Test
 	void shouldInstantiateWithConfigs() {
 		Map<String, Object> configs = new HashMap<>();
@@ -152,10 +144,10 @@ void shouldReturnUnmodifiableListenersList() {
 	}
 
 	@Test
-	void integrationTestDefaultShareConsumerFactory() throws Exception {
+	void integrationTestDefaultShareConsumerFactory(EmbeddedKafkaBroker broker) throws Exception {
 		final String topic = "embedded-share-test";
 		final String groupId = "testGroup";
-		var bootstrapServers = embeddedKafka.getBrokersAsString();
+		var bootstrapServers = broker.getBrokersAsString();
 
 		var producerProps = new java.util.Properties();
 		producerProps.put(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, bootstrapServers);