You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
GitHub instead ofJIRA in the contribution guidelines
* Replace JIRA ticket with GitHub issue in the contribution guidelines
* Changed the part about linking a Pull Request to a GitHub issue
* Fix code block
Copy file name to clipboardExpand all lines: CONTRIBUTING.adoc
+14-5Lines changed: 14 additions & 5 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -52,7 +52,7 @@ _you should see branches on origin as well as upstream, including 'master' and '
52
52
53
53
== A Day in the Life of a Contributor
54
54
55
-
* _Always_ work on topic branches (Typically use the Jira ticket ID as the branch name).
55
+
* _Always_ work on topic branches (Typically use the GitHub issue ID as the branch name).
56
56
- For example, to create and switch to a new branch for issue GH-123: `git checkout -b GH-123`
57
57
* You might be working on several different topic branches at any given time, but when at a stopping point for one of those branches, commit (a local operation).
58
58
* Please follow the "Commit Guidelines" described in
@@ -246,12 +246,15 @@ Make sure that all tests pass prior to submitting your pull request.
246
246
247
247
== Mention your pull request on the associated GitHub issue
248
248
249
-
Add a comment to the associated JIRA issue(s) linking to your new pull request.
249
+
Add a comment to the associated GitHub issue(s) linking to your new pull request.
250
250
251
-
== Provide a Link to the JIRA issue in the Associated Pull Request
251
+
== Provide a Link to the GitHub issue in the Associated Pull Request
252
252
253
-
Add a JIRA issue link to your first commit comment of the pull request on the last line, so your commit message
254
-
may look like this:
253
+
There are multiple ways to link a Pull Request to a GitHub issue as described
Copy file name to clipboardExpand all lines: README.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -62,7 +62,7 @@ Here are some ways for you to get involved in the community:
62
62
63
63
* Get involved with the Spring community on the Spring Community Forums. Please help out on the [StackOverflow](https://stackoverflow.com/questions/tagged/spring-kafka) by responding to questions and joining the debate.
64
64
* Create [GitHub issues](https://github.com/spring-projects/spring-kafka/issues) for bugs and new features and comment and vote on the ones that you are interested in.
65
-
* Github is for social coding: if you want to write code, we encourage contributions through pull requests from [forks of this repository](https://help.github.com/forking/). If you want to contribute code this way, please reference a JIRA ticket as well covering the specific issue you are addressing.
65
+
* Github is for social coding: if you want to write code, we encourage contributions through pull requests from [forks of this repository](https://help.github.com/forking/). If you want to contribute code this way, please reference a GitHub issue as well covering the specific issue you are addressing.
66
66
* Watch for upcoming articles on Spring by [subscribing](https://www.springsource.org/node/feed) to springframework.org
67
67
68
68
Before we accept a non-trivial patch or pull request we will need you to sign the [contributor's agreement](https://support.springsource.com/spring_committer_signup).
0 commit comments