GH-1559: Fix Sonar Issues

garyrussell · garyrussell · commit 45756992f240 · 2020-08-06T09:27:59.000-04:00
diff --git a/spring-kafka/src/main/java/org/springframework/kafka/listener/FailedRecordTracker.java b/spring-kafka/src/main/java/org/springframework/kafka/listener/FailedRecordTracker.java
@@ -142,8 +142,8 @@ private BackOff determineBackOff(ConsumerRecord<?, ?> record, Exception exceptio
 		if (this.backOffFunction == null) {
 			return this.backOff;
 		}
-		BackOff backOff = this.backOffFunction.apply(record, exception);
-		return backOff != null ? backOff : this.backOff;
+		BackOff backOffToUse = this.backOffFunction.apply(record, exception);
+		return backOffToUse != null ? backOffToUse : this.backOff;
 	}
 
 	private void attemptRecovery(ConsumerRecord<?, ?> record, Exception exception, @Nullable TopicPartition tp) {

Original file line number	Diff line number	Diff line change
`@@ -142,8 +142,8 @@ private BackOff determineBackOff(ConsumerRecord<?, ?> record, Exception exceptio`
`142`	`142`	`if (this.backOffFunction == null) {`
`143`	`143`	`return this.backOff;`
`144`	`144`	`}`
`145`		`- BackOff backOff = this.backOffFunction.apply(record, exception);`
`146`		`- return backOff != null ? backOff : this.backOff;`
	`145`	`+ BackOff backOffToUse = this.backOffFunction.apply(record, exception);`
	`146`	`+ return backOffToUse != null ? backOffToUse : this.backOff;`
`147`	`147`	`}`
`148`	`148`
`149`	`149`	`private void attemptRecovery(ConsumerRecord<?, ?> record, Exception exception, @Nullable TopicPartition tp) {`