Skip to content

Commit 90e9052

Browse files
Jean d'Arcgaryrussell
authored andcommitted
Add default header patterns to SimpleKHMapper
Fix indentation with tabs only
1 parent 8c8e56b commit 90e9052

File tree

2 files changed

+24
-4
lines changed

2 files changed

+24
-4
lines changed

spring-kafka/src/main/java/org/springframework/kafka/support/SimpleKafkaHeaderMapper.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,9 @@ public class SimpleKafkaHeaderMapper extends AbstractKafkaHeaderMapper {
4545
* consumer/producer records.
4646
*/
4747
public SimpleKafkaHeaderMapper() {
48-
super();
48+
super("!" + MessageHeaders.ID,
49+
"!" + MessageHeaders.TIMESTAMP,
50+
"*");
4951
}
5052

5153
/**

spring-kafka/src/test/java/org/springframework/kafka/support/SimpleKafkaHeaderMapperTests.java

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public class SimpleKafkaHeaderMapperTests {
3838

3939
@Test
4040
public void testSpecificStringConvert() {
41-
SimpleKafkaHeaderMapper mapper = new SimpleKafkaHeaderMapper("*");
41+
SimpleKafkaHeaderMapper mapper = new SimpleKafkaHeaderMapper();
4242
Map<String, Boolean> rawMappedHeaders = new HashMap<>();
4343
rawMappedHeaders.put("thisOnesAString", true);
4444
rawMappedHeaders.put("thisOnesBytes", false);
@@ -64,7 +64,7 @@ public void testSpecificStringConvert() {
6464

6565
@Test
6666
public void testNotStringConvert() {
67-
SimpleKafkaHeaderMapper mapper = new SimpleKafkaHeaderMapper("*");
67+
SimpleKafkaHeaderMapper mapper = new SimpleKafkaHeaderMapper();
6868
Map<String, Boolean> rawMappedHeaders = new HashMap<>();
6969
rawMappedHeaders.put("thisOnesBytes", false);
7070
mapper.setRawMappedHeaders(rawMappedHeaders);
@@ -87,7 +87,7 @@ public void testNotStringConvert() {
8787

8888
@Test
8989
public void testAlwaysStringConvert() {
90-
SimpleKafkaHeaderMapper mapper = new SimpleKafkaHeaderMapper("*");
90+
SimpleKafkaHeaderMapper mapper = new SimpleKafkaHeaderMapper();
9191
mapper.setMapAllStringsOut(true);
9292
Map<String, Boolean> rawMappedHeaders = new HashMap<>();
9393
rawMappedHeaders.put("thisOnesBytes", false);
@@ -111,4 +111,22 @@ public void testAlwaysStringConvert() {
111111
entry("neverConverted", "baz".getBytes()));
112112
}
113113

114+
@Test
115+
public void testDefaultHeaderPatterns() {
116+
SimpleKafkaHeaderMapper mapper = new SimpleKafkaHeaderMapper();
117+
mapper.setMapAllStringsOut(true);
118+
Map<String, Object> headersMap = new HashMap<>();
119+
headersMap.put(MessageHeaders.ID, "foo".getBytes());
120+
headersMap.put(MessageHeaders.TIMESTAMP, "bar");
121+
headersMap.put("thisOnePresent", "baz");
122+
MessageHeaders headers = new MessageHeaders(headersMap);
123+
Headers target = new RecordHeaders();
124+
mapper.fromHeaders(headers, target);
125+
assertThat(target).contains(
126+
new RecordHeader("thisOnePresent", "baz".getBytes()));
127+
headersMap.clear();
128+
mapper.toHeaders(target, headersMap);
129+
assertThat(headersMap).contains(
130+
entry("thisOnePresent", "baz".getBytes()));
131+
}
114132
}

0 commit comments

Comments
 (0)