Fix NullAway errors for array element type annotations

Change array field and getter annotations from @nullable element types
to non-nullable element types to match constructor expectations.

Arrays can still be null (reference nullable), but elements within
those arrays must be non-null, consistent with varargs constructors
that don't accept nullable elements.

Signed-off-by: Soby Chacko <[email protected]>

Author: sobychacko

spring-kafka/src/main/java/org/springframework/kafka/listener/AbstractMessageListenerContainer.java

@@ -157,7 +157,7 @@ protected AbstractMessageListenerContainer(@Nullable ConsumerFactory<? super K,
 		Assert.notNull(containerProperties, "'containerProperties' cannot be null");
 		Assert.notNull(consumerFactory, "'consumerFactory' cannot be null");
 		this.consumerFactory = (ConsumerFactory<K, V>) consumerFactory;
-		@Nullable String @Nullable [] topics = containerProperties.getTopics();
+		String @Nullable [] topics = containerProperties.getTopics();
 		if (topics != null) {
 			this.containerProperties = new ContainerProperties(topics);
 		}
@@ -167,7 +167,7 @@ protected AbstractMessageListenerContainer(@Nullable ConsumerFactory<? super K,
 				this.containerProperties = new ContainerProperties(topicPattern);
 			}
 			else {
-				@Nullable TopicPartitionOffset @Nullable [] topicPartitions = containerProperties.getTopicPartitions();
+				TopicPartitionOffset @Nullable [] topicPartitions = containerProperties.getTopicPartitions();
 				if (topicPartitions != null) {
 					this.containerProperties = new ContainerProperties(topicPartitions);
 				}

spring-kafka/src/main/java/org/springframework/kafka/listener/AbstractShareKafkaMessageListenerContainer.java

@@ -94,7 +94,7 @@ protected AbstractShareKafkaMessageListenerContainer(ShareConsumerFactory<? supe
 		Assert.notNull(containerProperties, "'containerProperties' cannot be null");
 		Assert.notNull(shareConsumerFactory, "'shareConsumerFactory' cannot be null");
 		this.shareConsumerFactory = (ShareConsumerFactory<K, V>) shareConsumerFactory;
-		@Nullable String @Nullable [] topics = containerProperties.getTopics();
+		String @Nullable [] topics = containerProperties.getTopics();
 		if (topics != null) {
 			this.containerProperties = new ContainerProperties(topics);
 		}
@@ -104,7 +104,7 @@ protected AbstractShareKafkaMessageListenerContainer(ShareConsumerFactory<? supe
 				this.containerProperties = new ContainerProperties(topicPattern);
 			}
 			else {
-				@Nullable TopicPartitionOffset @Nullable [] topicPartitions = containerProperties.getTopicPartitions();
+				TopicPartitionOffset @Nullable [] topicPartitions = containerProperties.getTopicPartitions();
 				if (topicPartitions != null) {
 					this.containerProperties = new ContainerProperties(topicPartitions);
 				}

spring-kafka/src/main/java/org/springframework/kafka/listener/ConsumerProperties.java

@@ -52,7 +52,7 @@ public class ConsumerProperties {
 	/**
 	 * Topic names.
 	 */
-	private final @Nullable String @Nullable [] topics;
+	private final String @Nullable [] topics;
 
 	/**
 	 * Topic pattern.
@@ -62,7 +62,7 @@ public class ConsumerProperties {
 	/**
 	 * Topics/partitions/initial offsets.
 	 */
-	private final @Nullable TopicPartitionOffset @Nullable [] topicPartitions;
+	private final TopicPartitionOffset @Nullable [] topicPartitions;
 
 	/**
 	 * The max time to block in the consumer waiting for records.
@@ -160,7 +160,6 @@ public ConsumerProperties(TopicPartitionOffset... topicPartitions) {
 	 * Return the configured topics.
 	 * @return the topics.
 	 */
-	@Nullable
 	public String @Nullable [] getTopics() {
 		return this.topics != null
 				? Arrays.copyOf(this.topics, this.topics.length)
@@ -181,7 +180,6 @@ public Pattern getTopicPattern() {
 	 * @return the topics/partitions.
 	 * @since 2.5
 	 */
-	@Nullable
 	public TopicPartitionOffset @Nullable [] getTopicPartitions() {
 		return this.topicPartitions != null
 				? Arrays.copyOf(this.topicPartitions, this.topicPartitions.length)

spring-kafka/src/main/java/org/springframework/kafka/retrytopic/ListenerContainerFactoryConfigurer.java

@@ -62,7 +62,7 @@ public class ListenerContainerFactoryConfigurer {
 	@Nullable
 	private BackOff providedBlockingBackOff;
 
-	private @Nullable Class<? extends Exception> @Nullable [] blockingExceptionTypes;
+	private Class<? extends Exception> @Nullable [] blockingExceptionTypes;
 
 	private boolean retainStandardFatal;