Fix Sonar issues

Author: garyrussell

spring-kafka-test/src/main/java/org/springframework/kafka/test/condition/EmbeddedKafkaCondition.java

@@ -115,10 +115,7 @@ private boolean springTestContext(AnnotatedElement annotatedElement) {
 	@SuppressWarnings("unchecked")
 	private EmbeddedKafkaBroker createBroker(EmbeddedKafka embedded) {
 		EmbeddedKafkaBroker broker;
-		int[] ports = embedded.ports();
-		if (embedded.count() > 1 && ports.length == 1 && ports[0] == 0) {
-			ports = new int[embedded.count()];
-		}
+		int[] ports = setupPorts(embedded);
 		broker = new EmbeddedKafkaBroker(embedded.count(), embedded.controlledShutdown(), embedded.topics())
 				.zkPort(embedded.zookeeperPort())
 				.kafkaPorts(ports);
@@ -162,6 +159,14 @@ private EmbeddedKafkaBroker createBroker(EmbeddedKafka embedded) {
 		return broker;
 	}
 
+	private int[] setupPorts(EmbeddedKafka embedded) {
+		int[] ports = embedded.ports();
+		if (embedded.count() > 1 && ports.length == 1 && ports[0] == 0) {
+			ports = new int[embedded.count()];
+		}
+		return ports;
+	}
+
 	private EmbeddedKafkaBroker getBrokerFromStore(ExtensionContext context) {
 		return getParentStore(context).get(EMBEDDED_BROKER, EmbeddedKafkaBroker.class) == null
 				? getStore(context).get(EMBEDDED_BROKER, EmbeddedKafkaBroker.class)

spring-kafka-test/src/main/java/org/springframework/kafka/test/context/EmbeddedKafkaContextCustomizer.java

@@ -66,10 +66,7 @@ public void customizeContext(ConfigurableApplicationContext context, MergedConte
 						.map(environment::resolvePlaceholders)
 						.toArray(String[]::new);
 
-		int[] ports = this.embeddedKafka.ports();
-		if (this.embeddedKafka.count() > 1 && ports.length == 1 && ports[0] == 0) {
-			ports = new int[this.embeddedKafka.count()];
-		}
+		int[] ports = setupPorts();
 		EmbeddedKafkaBroker embeddedKafkaBroker = new EmbeddedKafkaBroker(this.embeddedKafka.count(),
 					this.embeddedKafka.controlledShutdown(),
 					this.embeddedKafka.partitions(),
@@ -118,6 +115,14 @@ public void customizeContext(ConfigurableApplicationContext context, MergedConte
 		((DefaultSingletonBeanRegistry) beanFactory).registerDisposableBean(EmbeddedKafkaBroker.BEAN_NAME, embeddedKafkaBroker);
 	}
 
+	private int[] setupPorts() {
+		int[] ports = this.embeddedKafka.ports();
+		if (this.embeddedKafka.count() > 1 && ports.length == 1 && ports[0] == 0) {
+			ports = new int[this.embeddedKafka.count()];
+		}
+		return ports;
+	}
+
 	@Override
 	public int hashCode() {
 		return this.embeddedKafka.hashCode();