Skip to content

Commit e326722

Browse files
garyrussellartembilan
authored andcommitted
Deprecate KTU.senderProps()
1 parent 16a12fe commit e326722

File tree

7 files changed

+20
-8
lines changed

7 files changed

+20
-8
lines changed

spring-kafka-test/src/main/java/org/springframework/kafka/test/utils/KafkaTestUtils.java

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public static Map<String, Object> consumerProps(String group, String autoCommit,
8282
* @return the properties.
8383
*/
8484
public static Map<String, Object> producerProps(EmbeddedKafkaBroker embeddedKafka) {
85-
return senderProps(embeddedKafka.getBrokersAsString());
85+
return producerProps(embeddedKafka.getBrokersAsString());
8686
}
8787

8888

@@ -109,8 +109,9 @@ public static Map<String, Object> consumerProps(String brokers, String group, St
109109
* Set up test properties for an {@code <Integer, String>} producer.
110110
* @param brokers the bootstrapServers property.
111111
* @return the properties.
112+
* @since 2.3.5
112113
*/
113-
public static Map<String, Object> senderProps(String brokers) {
114+
public static Map<String, Object> producerProps(String brokers) {
114115
Map<String, Object> props = new HashMap<>();
115116
props.put(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, brokers);
116117
props.put(ProducerConfig.RETRIES_CONFIG, 0);
@@ -122,6 +123,17 @@ public static Map<String, Object> senderProps(String brokers) {
122123
return props;
123124
}
124125

126+
/**
127+
* Set up test properties for an {@code <Integer, String>} producer.
128+
* @param brokers the bootstrapServers property.
129+
* @return the properties.
130+
* @deprecated in favor of {@link #producerProps(String)}.
131+
*/
132+
@Deprecated
133+
public static Map<String, Object> senderProps(String brokers) {
134+
return producerProps(brokers);
135+
}
136+
125137
/**
126138
* Poll the consumer, expecting a single record for the specified topic.
127139
* @param consumer the consumer.

spring-kafka/src/test/java/org/springframework/kafka/core/reactive/ReactiveKafkaProducerTemplateIntegrationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ public void setUp() {
109109

110110
private SenderOptions<Integer, String> setupSenderOptionsWithDefaultTopic() {
111111
Map<String, Object> senderProps =
112-
KafkaTestUtils.senderProps(EmbeddedKafkaCondition.getBroker().getBrokersAsString());
112+
KafkaTestUtils.producerProps(EmbeddedKafkaCondition.getBroker().getBrokersAsString());
113113
return SenderOptions.create(senderProps);
114114
}
115115

spring-kafka/src/test/java/org/springframework/kafka/core/reactive/ReactiveKafkaProducerTemplateTransactionIntegrationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ public void setUp() {
9797

9898
private SenderOptions<Integer, String> setupSenderOptionsWithDefaultTopic() {
9999
Map<String, Object> senderProps =
100-
KafkaTestUtils.senderProps(EmbeddedKafkaCondition.getBroker().getBrokersAsString());
100+
KafkaTestUtils.producerProps(EmbeddedKafkaCondition.getBroker().getBrokersAsString());
101101
SenderOptions<Integer, String> senderOptions = SenderOptions.create(senderProps);
102102
senderOptions = senderOptions
103103
.producerProperty(ProducerConfig.TRANSACTIONAL_ID_CONFIG, "reactive.transaction")

spring-kafka/src/test/java/org/springframework/kafka/streams/KafkaStreamsBranchTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ public ProducerFactory<Integer, String> producerFactory() {
134134

135135
@Bean
136136
public Map<String, Object> producerConfigs() {
137-
return KafkaTestUtils.senderProps(this.brokerAddresses);
137+
return KafkaTestUtils.producerProps(this.brokerAddresses);
138138
}
139139

140140
@Bean

spring-kafka/src/test/java/org/springframework/kafka/streams/KafkaStreamsJsonSerializationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ public static class Config {
191191

192192
@Bean
193193
public Map<String, Object> producerConfigs() {
194-
Map<String, Object> senderProps = KafkaTestUtils.senderProps(this.brokerAddresses);
194+
Map<String, Object> senderProps = KafkaTestUtils.producerProps(this.brokerAddresses);
195195
senderProps.put(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG, JsonSerializer.class);
196196
senderProps.put(ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG, JsonSerializer.class);
197197
return senderProps;

spring-kafka/src/test/java/org/springframework/kafka/streams/KafkaStreamsTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ public ProducerFactory<Integer, String> producerFactory() {
181181

182182
@Bean
183183
public Map<String, Object> producerConfigs() {
184-
return KafkaTestUtils.senderProps(this.brokerAddresses);
184+
return KafkaTestUtils.producerProps(this.brokerAddresses);
185185
}
186186

187187
@Bean

spring-kafka/src/test/java/org/springframework/kafka/streams/RecoveringDeserializationExceptionHandlerTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ public ProducerFactory<byte[], byte[]> producerFactory() {
169169

170170
@Bean
171171
public Map<String, Object> producerConfigs() {
172-
Map<String, Object> senderProps = KafkaTestUtils.senderProps(this.brokerAddresses);
172+
Map<String, Object> senderProps = KafkaTestUtils.producerProps(this.brokerAddresses);
173173
senderProps.put(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG, ByteArraySerializer.class);
174174
senderProps.put(ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG, ByteArraySerializer.class);
175175
return senderProps;

0 commit comments

Comments
 (0)