From 91376de75c9b340fe52bdf4714c492fe26247cf7 Mon Sep 17 00:00:00 2001
From: cfredri4 <christian.fredriksson.2@volvocars.com>
Date: Wed, 5 Mar 2025 14:53:40 +0100
Subject: [PATCH] Fix KafkaTemplate hiding exceptions when starting observation

This fixes that exceptions thrown from observation.start() are hidden by KafkaTemplate throwing a new exception due to registering observation error without successfully starting the observation.
Signed-off-by: Christian Fredriksson <christian.fredriksson.2@volvocars.com>
---
 .../main/java/org/springframework/kafka/core/KafkaTemplate.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/spring-kafka/src/main/java/org/springframework/kafka/core/KafkaTemplate.java b/spring-kafka/src/main/java/org/springframework/kafka/core/KafkaTemplate.java
index 78a6c315d6..cd38a39a0c 100644
--- a/spring-kafka/src/main/java/org/springframework/kafka/core/KafkaTemplate.java
+++ b/spring-kafka/src/main/java/org/springframework/kafka/core/KafkaTemplate.java
@@ -805,8 +805,8 @@ private CompletableFuture<SendResult<K, V>> observeSend(final ProducerRecord<K,
 				this.observationConvention, DefaultKafkaTemplateObservationConvention.INSTANCE,
 				() -> new KafkaRecordSenderContext(producerRecord, this.beanName, this::clusterId),
 				this.observationRegistry);
+		observation.start();
 		try {
-			observation.start();
 			try (Observation.Scope ignored = observation.openScope()) {
 				return doSend(producerRecord, observation);
 			}