Skip to content

Conversation

@sullis
Copy link
Contributor

@sullis sullis commented Apr 16, 2025

This PR validates the @ Headers annotation

https://docs.spring.io/spring-kafka/reference/kafka/headers.html

@sobychacko sobychacko added this to the 4.0.0-M2 milestone Apr 16, 2025
@sobychacko
Copy link
Contributor

@sullis Could you add your name as an author to the test class?

@sobychacko
Copy link
Contributor

Also, there are some checkstyle failures in the build: https://github.com/spring-projects/spring-kafka/actions/runs/14496676439/job/40666757398?pr=3844

@sullis sullis force-pushed the sullis/headers-annotation-test branch from c49d2e1 to 5c7d7b8 Compare April 16, 2025 16:09
@sullis
Copy link
Contributor Author

sullis commented Apr 16, 2025

@sullis Could you add your name as an author to the test class?

Done.

@sullis sullis force-pushed the sullis/headers-annotation-test branch from 5c7d7b8 to 0531648 Compare April 16, 2025 16:17
@sullis
Copy link
Contributor Author

sullis commented Apr 16, 2025

Also, there are some checkstyle failures in the build: https://github.com/spring-projects/spring-kafka/actions/runs/14496676439/job/40666757398?pr=3844

Fixed.

@sobychacko sobychacko merged commit c3fc82b into spring-projects:main Apr 16, 2025
3 checks passed
@sullis sullis deleted the sullis/headers-annotation-test branch April 16, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants