Skip to content

#3915 #3916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

#3915 #3916

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions spring-kafka/src/main/java/org/springframework/kafka/core/DefaultKafkaProducerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1181,13 +1181,11 @@ public void commitTransaction() throws ProducerFencedException {

@Override
public void abortTransaction() throws ProducerFencedException {
Exception producerFailedToUse = this.producerFailed;
LOGGER.debug(() -> toString() + " abortTransaction()");
Copy link
Member

@artembilan artembilan May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are already here, would you mind fixing this line as well?

Suggested change
LOGGER.debug(() -> toString() + " abortTransaction()");
LOGGER.debug(() -> this + " abortTransaction()");

if (this.producerFailed != null) {
LOGGER.debug(() -> {
String message = this.producerFailed == null ? "" : this.producerFailed.getMessage();
return "abortTransaction ignored - previous txFailed: " + message
+ ": " + this;
});
if (producerFailedToUse != null) {
LOGGER.debug(() -> "abortTransaction ignored - previous txFailed: " + producerFailedToUse.getMessage()
+ ": " + this);
}
else {
try {
Expand Down