Skip to content

Improve performance of ContainerProperties and ConsumerProperties toString() methods using StringBuilder #4013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 28, 2025
Merged

Improve performance of ContainerProperties and ConsumerProperties toString() methods using StringBuilder #4013

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
797da20
Improve toString() performance with StringBuilder
cwangg897 Jul 28, 2025
9e6c926
Skip null fields in toString() output
cwangg897 Jul 28, 2025
d81bdbb
Apply Spring code style using spring-framework.xml
cwangg897 Jul 28, 2025
39055f2
Remove trailing whitespace to fix checkstyle violations
cwangg897 Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions spring-kafka/src/main/java/org/springframework/kafka/listener/ContainerProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1131,7 +1131,6 @@ public String toString() {

// Listener configuration
appendProperty(sb, "messageListener", this.messageListener);
appendProperty(sb, "messageListener", this.messageListener);
appendProperty(sb, "listenerTaskExecutor", this.listenerTaskExecutor);

// Idle event configuration
Expand Down Expand Up @@ -1193,7 +1192,9 @@ public String toString() {
* @param value the property value
*/
private void appendProperty(StringBuilder sb, String name, @Nullable Object value) {
sb.append("\n ").append(name).append("=").append(value);
if(value != null){
Copy link
Member

@artembilan artembilan Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have not run check locally.
This is not a code style we follow.
See if you can apply src/idea/spring-framework.xml into your IntelliJ IDEA for our Spring-specific code style.

Copy link
Contributor Author

@cwangg897 cwangg897 Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I saw your comment after opening the PR.
I'll fix it locally and push the update soon.
Please wait a moment. Thank you!

Copy link
Contributor Author

@cwangg897 cwangg897 Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artembilan
I'm sorry for keeping you waiting.
This is my first time contributing to open source, so I was a bit clumsy.
Thanks to your help, I was able to resolve the issue and learned a lot.
If there's anything else I should fix, please feel free to let me know.
I really appreciate your time and guidance. Thank you!

Copy link
Member

@artembilan artembilan Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem! All good.
We do have this guidance, though: https://github.com/spring-projects/spring-kafka/blob/main/CONTRIBUTING.adoc.

Please, let us know if that is good enough to make your contribution routine smooth.
I do see that we need to mention that src/idea/spring-framework.xml code style config over there.
Plus, we don't need to update Copyright anymore 😄 .

But who knows what else causes headache for you but we can help to avoid it with some simple improvement to the process.
Thank you!

sb.append("\n ").append(name).append("=").append(value);
}
}


Expand Down