Skip to content

Refactor newTopics to remove nested loops #4026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2025
Merged

Refactor newTopics to remove nested loops #4026

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1a7ce9
Refactor newTopics to remove nested loops
cwangg897 Jul 28, 2025
e0dadd5
Refactor newTopics filtering with removeIf
cwangg897 Jul 29, 2025
69d8820
Simplify newTopics logic to use List instead of Map
cwangg897 Jul 30, 2025
bf400f5
Refactor topic filtering in KafkaAdmin.newTopics
cwangg897 Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 12 additions & 21 deletions spring-kafka/src/main/java/org/springframework/kafka/core/KafkaAdmin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
import java.util.Iterator;
import java.util.LinkedList;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -333,30 +332,22 @@ protected Collection<NewTopic> newTopics() {
Map<String, NewTopic> topicsForRetry = newTopicsMap.entrySet().stream()
.filter(entry -> entry.getValue() instanceof TopicForRetryable)
.collect(Collectors.toMap(Entry::getKey, Entry::getValue));
Map<String, String> topicNameToMapKey = new HashMap<>();
Copy link
Member

@artembilan artembilan Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't believe in this extra map.
More over its name does not reflect reality.
That this.applicationContext.getBeansOfType() returns for us a map of bean names to beans.
Doesn't look like we deal with bean names over here in this method at all.
So, we could simplify the logic just to deal with a List<NewTopic> in this method.
Then those topicsForRetry could be just topic names, since according to its logic we deliberately aware that those names are only for TopicForRetryable.
And so on from here, down to a single removeIf() in the end.

for (Entry<String, NewTopic> entry : newTopicsMap.entrySet()) {
topicNameToMapKey.put(entry.getValue().name(), entry.getKey());
}

for (Entry<String, NewTopic> entry : topicsForRetry.entrySet()) {
Iterator<Entry<String, NewTopic>> iterator = newTopicsMap.entrySet().iterator();
boolean remove = false;
while (iterator.hasNext()) {
Entry<String, NewTopic> nt = iterator.next();
// if we have a NewTopic and TopicForRetry with the same name, remove the latter
if (nt.getValue().name().equals(entry.getValue().name())
&& !(nt.getValue() instanceof TopicForRetryable)) {

remove = true;
break;
String retryTopicName = entry.getValue().name();
String keyInNewTopicsMap = topicNameToMapKey.get(retryTopicName);
if (keyInNewTopicsMap != null) {
NewTopic existing = newTopicsMap.get(keyInNewTopicsMap);
if (!(existing instanceof TopicForRetryable)) {
newTopicsMap.remove(keyInNewTopicsMap);
}
}
if (remove) {
newTopicsMap.remove(entry.getKey());
}
}
Iterator<Entry<String, NewTopic>> iterator = newTopicsMap.entrySet().iterator();
while (iterator.hasNext()) {
Entry<String, NewTopic> next = iterator.next();
if (!this.createOrModifyTopic.test(next.getValue())) {
iterator.remove();
}
}
newTopicsMap.entrySet().removeIf(entry -> !this.createOrModifyTopic.test(entry.getValue()));
return new ArrayList<>(newTopicsMap.values());
}

Expand Down
Loading