You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix references to invalid 'ackTimeout' property (#1015) (#1016)
The docs has code examples using a consumer property named
`ackTimeout`. However, the actual property name is
`ackTimeoutMillis`. This updates those references.
Resolves#1010
(cherry picked from commit 03c0da3)
Copy file name to clipboardExpand all lines: spring-pulsar-docs/src/main/antora/modules/ROOT/pages/reference/pulsar/message-consumption.adoc
+5-5Lines changed: 5 additions & 5 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -631,12 +631,12 @@ Apache Pulsar provides various native strategies for message redelivery and erro
631
631
By default, Pulsar consumers do not redeliver messages unless the consumer crashes, but you can change this behavior by setting an ack timeout on the Pulsar consumer.
632
632
If the ack timeout property has a value above zero and if the Pulsar consumer does not acknowledge a message within that timeout period, the message is redelivered.
633
633
634
-
When you use Spring for Apache Pulsar, you can set this property via a <<_consumer_customization_on_pulsarlistener,consumer customizer>> or with the native Pulsar `ackTimeout` property in the `properties` attribute of `@PulsarListener`:
634
+
When you use Spring for Apache Pulsar, you can set this property via a <<_consumer_customization_on_pulsarlistener,consumer customizer>> or with the native Pulsar `ackTimeoutMillis` property in the `properties` attribute of `@PulsarListener`:
@@ -749,7 +749,7 @@ This bean specifies a number of things, such as the max delivery (10, in this ca
749
749
If you do not specify a DLQ topic name, it defaults to `<topicname>-<subscriptionname>-DLQ` in Pulsar.
750
750
Next, we provide this bean name to `PulsarListener` by setting the `deadLetterPolicy` property.
751
751
Note that the `PulsarListener` has a subscription type of `Shared`, as the DLQ feature only works with shared subscriptions.
752
-
This code is primarily for demonstration purposes, so we provide an `ackTimeout` value of 1 second.
752
+
This code is primarily for demonstration purposes, so we provide an `ackTimeoutMillis` value of 1000.
753
753
The idea is that the code throws the exception and, if Pulsar does not receive an ack within 1 second, it does a retry.
754
754
If that cycle continues ten times (as that is our max redelivery count in the `DeadLetterPolicy`), the Pulsar consumer publishes the messages to the DLQ topic.
755
755
We have another `PulsarListener` that listens on the DLQ topic to receive data as it is published to the DLQ topic.
Copy file name to clipboardExpand all lines: spring-pulsar-docs/src/main/antora/modules/ROOT/pages/reference/reactive-pulsar/reactive-message-consumption.adoc
return b -> b.property("ackTimeoutMillis", "1000");
347
348
}
348
349
}
349
350
----
@@ -353,7 +354,7 @@ This bean specifies a number of things, such as the max delivery (10, in this ca
353
354
If you do not specify a DLQ topic name, it defaults to `<topicname>-<subscriptionname>-DLQ` in Pulsar.
354
355
Next, we provide this bean name to `ReactivePulsarListener` by setting the `deadLetterPolicy` property.
355
356
Note that the `ReactivePulsarListener` has a subscription type of `Shared`, as the DLQ feature only works with shared subscriptions.
356
-
This code is primarily for demonstration purposes, so we provide an `ackTimeout` value of 1 second.
357
+
This code is primarily for demonstration purposes, so we provide an `ackTimeoutMillis` value of 1000.
357
358
The idea is that the code throws the exception and, if Pulsar does not receive an ack within 1 second, it does a retry.
358
359
If that cycle continues ten times (as that is our max redelivery count in the `DeadLetterPolicy`), the Pulsar consumer publishes the messages to the DLQ topic.
359
360
We have another `ReactivePulsarListener` that listens on the DLQ topic to receive data as it is published to the DLQ topic.
0 commit comments