feat: extract ensureTopicsPatternFullyQualified method and add unit tests

Signed-off-by: oneby-wang <[email protected]>

Author: oneby-wang

spring-pulsar-reactive/src/main/java/org/springframework/pulsar/reactive/core/DefaultReactivePulsarConsumerFactory.java

@@ -87,6 +87,7 @@ public ReactiveMessageConsumer<T> createConsumer(Schema<T> schema,
 			customizers.forEach((c) -> c.customize(consumerBuilder));
 		}
 		this.ensureTopicNamesFullyQualified(consumerBuilder);
+		this.ensureTopicsPatternFullyQualified(consumerBuilder);
 		return consumerBuilder.build();
 	}
 
@@ -100,6 +101,13 @@ protected void ensureTopicNamesFullyQualified(ReactiveMessageConsumerBuilder<T>
 			var fullyQualifiedTopics = topics.stream().map(this.topicBuilder::getFullyQualifiedNameForTopic).toList();
 			mutableSpec.setTopicNames(fullyQualifiedTopics);
 		}
+	}
+
+	protected void ensureTopicsPatternFullyQualified(ReactiveMessageConsumerBuilder<T> consumerBuilder) {
+		if (this.topicBuilder == null) {
+			return;
+		}
+		var mutableSpec = consumerBuilder.getMutableSpec();
 		var topicsPattern = mutableSpec.getTopicsPattern();
 		if (topicsPattern != null && StringUtils.isNoneBlank(topicsPattern.pattern())) {
 			var topicsPatternStr = topicsPattern.pattern();

spring-pulsar-reactive/src/test/java/org/springframework/pulsar/reactive/core/DefaultReactivePulsarConsumerFactoryTests.java

@@ -22,6 +22,7 @@
 
 import java.util.Collections;
 import java.util.List;
+import java.util.regex.Pattern;
 
 import org.apache.pulsar.client.api.PulsarClient;
 import org.apache.pulsar.client.api.Schema;
@@ -112,7 +113,7 @@ void createConsumerWithCustomizer() {
 	class FactoryCreatedWithTopicBuilder {
 
 		@Test
-		void createConsumer() {
+		void createConsumerEnsureTopicNamesFullyQualified() {
 			var topicBuilder = spy(new PulsarTopicBuilder());
 			var consumerFactory = new DefaultReactivePulsarConsumerFactory<String>(
 					AdaptedReactivePulsarClientFactory.create((PulsarClient) null), null);
@@ -127,6 +128,23 @@ void createConsumer() {
 			verify(topicBuilder).getFullyQualifiedNameForTopic(inputTopic);
 		}
 
+		@Test
+		void createConsumerEnsureTopicsPatternFullyQualified() {
+			var topicBuilder = spy(new PulsarTopicBuilder());
+			var consumerFactory = new DefaultReactivePulsarConsumerFactory<String>(
+					AdaptedReactivePulsarClientFactory.create((PulsarClient) null), null);
+			consumerFactory.setTopicBuilder(topicBuilder);
+			var inputTopicsPattern = "my-topic-.*";
+			var fullyQualifiedTopicsPattern = "persistent://public/default/my-topic-.*";
+			var consumer = consumerFactory.createConsumer(SCHEMA,
+					Collections.singletonList(builder -> builder.topicsPattern(Pattern.compile(inputTopicsPattern))));
+			ReactiveMessageConsumerSpec reactiveMessageConsumerSpec = assertThat(consumer)
+				.extracting("consumerSpec", InstanceOfAssertFactories.type(ReactiveMessageConsumerSpec.class))
+				.actual();
+			assertThat(reactiveMessageConsumerSpec.getTopicsPattern().pattern()).isEqualTo(fullyQualifiedTopicsPattern);
+			verify(topicBuilder).getFullyQualifiedNameForTopic(inputTopicsPattern);
+		}
+
 	}
 
 }

spring-pulsar/src/main/java/org/springframework/pulsar/core/DefaultPulsarConsumerFactory.java

@@ -119,6 +119,7 @@ public Consumer<T> createConsumer(Schema<T> schema, @Nullable Collection<String>
 			customizers.forEach(customizer -> customizer.customize(consumerBuilder));
 		}
 		this.ensureTopicNamesFullyQualified(consumerBuilder);
+		this.ensureTopicsPatternFullyQualified(consumerBuilder);
 		try {
 			return consumerBuilder.subscribe();
 		}
@@ -148,6 +149,13 @@ protected void ensureTopicNamesFullyQualified(ConsumerBuilder<T> builder) {
 			var fullyQualifiedTopics = topics.stream().map(this.topicBuilder::getFullyQualifiedNameForTopic).toList();
 			builderImpl.getConf().setTopicNames(new HashSet<>(fullyQualifiedTopics));
 		}
+	}
+
+	protected void ensureTopicsPatternFullyQualified(ConsumerBuilder<T> builder) {
+		if (this.topicBuilder == null) {
+			return;
+		}
+		var builderImpl = (ConsumerBuilderImpl<T>) builder;
 		var topicsPattern = builderImpl.getConf().getTopicsPattern();
 		if (topicsPattern != null && StringUtils.isNoneBlank(topicsPattern.pattern())) {
 			var topicsPatternStr = topicsPattern.pattern();

spring-pulsar/src/test/java/org/springframework/pulsar/core/DefaultPulsarConsumerFactoryTests.java

@@ -27,12 +27,15 @@
 import java.util.Collections;
 import java.util.List;
 import java.util.Map;
+import java.util.concurrent.CompletableFuture;
 
 import org.apache.pulsar.client.api.ConsumerBuilder;
 import org.apache.pulsar.client.api.PulsarClient;
 import org.apache.pulsar.client.api.PulsarClientException;
 import org.apache.pulsar.client.api.PulsarClientException.InvalidConfigurationException;
 import org.apache.pulsar.client.api.Schema;
+import org.apache.pulsar.client.impl.PatternMultiTopicsConsumerImpl;
+import org.assertj.core.api.InstanceOfAssertFactories;
 import org.jspecify.annotations.Nullable;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
@@ -271,26 +274,44 @@ void multipleConfigCustomizers() throws PulsarClientException {
 	@Nested
 	class CreateConsumerUsingPulsarTopicBuilder {
 
-		private DefaultPulsarConsumerFactory<String> consumerFactory;
-
-		private PulsarTopicBuilder pulsarTopicBuilder;
-
-		@BeforeEach
-		void createConsumerFactory() {
-			pulsarTopicBuilder = spy(new PulsarTopicBuilder());
-			consumerFactory = new DefaultPulsarConsumerFactory<>(pulsarClient, null);
-			consumerFactory.setTopicBuilder(pulsarTopicBuilder);
-		}
-
 		@Test
-		void withPulsarTopicBuilder() throws PulsarClientException {
+		void withPulsarTopicBuilderEnsureTopicNamesFullyQualified() throws PulsarClientException {
+			var pulsarTopicBuilder = spy(new PulsarTopicBuilder());
+			DefaultPulsarConsumerFactory<String> consumerFactory = new DefaultPulsarConsumerFactory<>(pulsarClient,
+					null);
+			consumerFactory.setTopicBuilder(pulsarTopicBuilder);
 			try (var consumer = consumerFactory.createConsumer(SCHEMA, Collections.singletonList("topic1"),
-					"with-pulsar-topic-builder-sub", null, null)) {
+					"with-pulsar-topic-builder-ensure-topic-names-fully-qualified-sub", null, null)) {
 				assertThat(consumer.getTopic()).isEqualTo("persistent://public/default/topic1");
 				verify(pulsarTopicBuilder).getFullyQualifiedNameForTopic("topic1");
 			}
 		}
 
+		@Test
+		void withPulsarTopicBuilderEnsureTopicsPatternFullyQualified() throws PulsarClientException {
+			var pulsarTopicBuilder = spy(new PulsarTopicBuilder());
+			ConsumerBuilderCustomizer<String> customizer = (builder) -> builder.topicsPattern("topic-.*");
+			DefaultPulsarConsumerFactory<String> consumerFactory = new DefaultPulsarConsumerFactory<>(pulsarClient,
+					List.of(customizer));
+			consumerFactory.setTopicBuilder(pulsarTopicBuilder);
+
+			try (var consumer = consumerFactory.createConsumer(SCHEMA, null,
+					"with-pulsar-topic-builder-ensure-topics-pattern-fully-qualified-sub", null, null)) {
+				assertThat(consumer).isInstanceOf(PatternMultiTopicsConsumerImpl.class);
+				var patternMultiTopicsConsumer = (PatternMultiTopicsConsumerImpl<String>) consumer;
+				var topicsPattern = patternMultiTopicsConsumer.getPattern();
+				assertThat(topicsPattern.inputPattern()).isEqualTo("persistent://public/default/topic-.*");
+				verify(pulsarTopicBuilder).getFullyQualifiedNameForTopic("topic-.*");
+				CompletableFuture<?> watcherFuture = assertThat(patternMultiTopicsConsumer)
+					.extracting("watcherFuture", InstanceOfAssertFactories.type(CompletableFuture.class))
+					.actual();
+				// Seems some bugs in PatternMultiTopicsConsumerImpl.closeAsync() method.
+				// If watcherFuture is not completed, invoke pulsarClient.close() first
+				// will cause exception.
+				watcherFuture.join();
+			}
+		}
+
 	}
 
 }