Skip to content

Commit 10948b5

Browse files
committed
Make OpenSamlAssertingPartyDetails Serializable
Closes gh-17622
1 parent 98b377c commit 10948b5

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed

config/src/test/java/org/springframework/security/SerializationSamples.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,12 +171,14 @@
171171
import org.springframework.security.saml2.provider.service.authentication.Saml2AuthenticationToken;
172172
import org.springframework.security.saml2.provider.service.authentication.Saml2PostAuthenticationRequest;
173173
import org.springframework.security.saml2.provider.service.authentication.Saml2RedirectAuthenticationRequest;
174+
import org.springframework.security.saml2.provider.service.authentication.TestOpenSamlObjects;
174175
import org.springframework.security.saml2.provider.service.authentication.TestSaml2AuthenticationTokens;
175176
import org.springframework.security.saml2.provider.service.authentication.TestSaml2Authentications;
176177
import org.springframework.security.saml2.provider.service.authentication.TestSaml2LogoutRequests;
177178
import org.springframework.security.saml2.provider.service.authentication.TestSaml2PostAuthenticationRequests;
178179
import org.springframework.security.saml2.provider.service.authentication.TestSaml2RedirectAuthenticationRequests;
179180
import org.springframework.security.saml2.provider.service.authentication.logout.Saml2LogoutRequest;
181+
import org.springframework.security.saml2.provider.service.registration.OpenSamlAssertingPartyDetails;
180182
import org.springframework.security.saml2.provider.service.registration.RelyingPartyRegistration;
181183
import org.springframework.security.saml2.provider.service.registration.TestRelyingPartyRegistrations;
182184
import org.springframework.security.web.PortResolverImpl;
@@ -522,6 +524,11 @@ final class SerializationSamples {
522524
return token;
523525
});
524526
generatorByClassName.put(Saml2LogoutRequest.class, (r) -> TestSaml2LogoutRequests.create());
527+
generatorByClassName.put(OpenSamlAssertingPartyDetails.class,
528+
(r) -> OpenSamlAssertingPartyDetails
529+
.withEntityDescriptor(
530+
TestOpenSamlObjects.entityDescriptor(TestRelyingPartyRegistrations.full().build()))
531+
.build());
525532

526533
// web
527534
generatorByClassName.put(AnonymousAuthenticationToken.class, (r) -> {

saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/registration/OpenSamlAssertingPartyDetails.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package org.springframework.security.saml2.provider.service.registration;
1818

19+
import java.io.Serial;
1920
import java.security.cert.CertificateException;
2021
import java.security.cert.X509Certificate;
2122
import java.util.ArrayList;
@@ -46,7 +47,10 @@
4647
*/
4748
public final class OpenSamlAssertingPartyDetails extends RelyingPartyRegistration.AssertingPartyDetails {
4849

49-
private final EntityDescriptor descriptor;
50+
@Serial
51+
private static final long serialVersionUID = -2412785556799182734L;
52+
53+
private final transient EntityDescriptor descriptor;
5054

5155
OpenSamlAssertingPartyDetails(RelyingPartyRegistration.AssertingPartyDetails details, EntityDescriptor descriptor) {
5256
super(details.getEntityId(), details.getWantAuthnRequestsSigned(), details.getSigningAlgorithms(),

0 commit comments

Comments
 (0)