Use String#isEmpty

Signed-off-by: Tran Ngoc Nhan <[email protected]>

Author: ngocnhan-tran1996

cas/src/main/java/org/springframework/security/cas/web/authentication/DefaultServiceAuthenticationDetails.java

@@ -110,7 +110,7 @@ private String getQueryString(final HttpServletRequest request, final Pattern ar
 			return null;
 		}
 		String result = artifactPattern.matcher(query).replaceFirst("");
-		if (result.length() == 0) {
+		if (result.isEmpty()) {
 			return null;
 		}
 		// strip off the trailing & only if the artifact was the first query param

core/src/main/java/org/springframework/security/access/annotation/Jsr250MethodSecurityMetadataSource.java

@@ -108,7 +108,7 @@ private String getRoleWithDefaultPrefix(String role) {
 		if (role == null) {
 			return role;
 		}
-		if (this.defaultRolePrefix == null || this.defaultRolePrefix.length() == 0) {
+		if (this.defaultRolePrefix == null || this.defaultRolePrefix.isEmpty()) {
 			return role;
 		}
 		if (role.startsWith(this.defaultRolePrefix)) {

core/src/main/java/org/springframework/security/access/expression/SecurityExpressionRoot.java

@@ -236,7 +236,7 @@ private static String getRoleWithDefaultPrefix(@Nullable String defaultRolePrefi
 		if (role == null) {
 			return role;
 		}
-		if (defaultRolePrefix == null || defaultRolePrefix.length() == 0) {
+		if (defaultRolePrefix == null || defaultRolePrefix.isEmpty()) {
 			return role;
 		}
 		if (role.startsWith(defaultRolePrefix)) {

crypto/src/main/java/org/springframework/security/crypto/password/AbstractValidatingPasswordEncoder.java

@@ -32,8 +32,7 @@ public abstract class AbstractValidatingPasswordEncoder implements PasswordEncod
 
 	@Override
 	public final boolean matches(@Nullable CharSequence rawPassword, @Nullable String encodedPassword) {
-		if (rawPassword == null || rawPassword.length() == 0 || encodedPassword == null
-				|| encodedPassword.length() == 0) {
+		if (rawPassword == null || rawPassword.isEmpty() || encodedPassword == null || encodedPassword.isEmpty()) {
 			return false;
 		}
 		return matchesNonNull(rawPassword.toString(), encodedPassword);
@@ -43,7 +42,7 @@ public final boolean matches(@Nullable CharSequence rawPassword, @Nullable Strin
 
 	@Override
 	public final boolean upgradeEncoding(@Nullable String encodedPassword) {
-		if (encodedPassword == null || encodedPassword.length() == 0) {
+		if (encodedPassword == null || encodedPassword.isEmpty()) {
 			return false;
 		}
 		return upgradeEncodingNonNull(encodedPassword);

web/src/main/java/org/springframework/security/web/authentication/rememberme/AbstractRememberMeServices.java

@@ -129,7 +129,7 @@ public Authentication autoLogin(HttpServletRequest request, HttpServletResponse
 			return null;
 		}
 		this.logger.debug("Remember-me cookie detected");
-		if (rememberMeCookie.length() == 0) {
+		if (rememberMeCookie.isEmpty()) {
 			this.logger.debug("Cookie was empty");
 			cancelCookie(request, response);
 			return null;
@@ -382,7 +382,7 @@ protected void setCookie(String[] tokens, int maxAge, HttpServletRequest request
 
 	private String getCookiePath(HttpServletRequest request) {
 		String contextPath = request.getContextPath();
-		return (contextPath.length() > 0) ? contextPath : "/";
+		return contextPath.isEmpty() ? "/" : contextPath;
 	}
 
 	/**

web/src/main/java/org/springframework/security/web/firewall/RequestWrapper.java

@@ -56,7 +56,7 @@ final class RequestWrapper extends FirewalledRequest {
 		super(request);
 		this.strippedServletPath = strip(request.getServletPath());
 		String pathInfo = strip(request.getPathInfo());
-		if (pathInfo != null && pathInfo.length() == 0) {
+		if (pathInfo != null && pathInfo.isEmpty()) {
 			pathInfo = null;
 		}
 		this.strippedPathInfo = pathInfo;

web/src/main/java/org/springframework/security/web/savedrequest/DefaultSavedRequest.java

@@ -378,7 +378,7 @@ private static String createQueryString(String queryString, String matchingReque
 		if (matchingRequestParameterName == null) {
 			return queryString;
 		}
-		if (queryString == null || queryString.length() == 0) {
+		if (queryString == null || queryString.isEmpty()) {
 			return matchingRequestParameterName;
 		}
 		return UriComponentsBuilder.newInstance()

web/src/main/java/org/springframework/security/web/util/TextEscapeUtils.java

@@ -25,7 +25,7 @@
 public abstract class TextEscapeUtils {
 
 	public static String escapeEntities(String s) {
-		if (s == null || s.length() == 0) {
+		if (s == null || s.isEmpty()) {
 			return s;
 		}
 		StringBuilder sb = new StringBuilder();

web/src/test/java/org/springframework/security/web/firewall/RequestWrapperTests.java

@@ -73,7 +73,7 @@ public void pathParametersAreRemovedFromPathInfo() {
 			String path = entry.getKey();
 			String expectedResult = entry.getValue();
 			// Should be null when stripped value is empty
-			if (expectedResult.length() == 0) {
+			if (expectedResult.isEmpty()) {
 				expectedResult = null;
 			}
 			request.setPathInfo(path);