Deprecate loadContext(RequestResponseHolder)

Fix gh-11032

Author: rwinch

web/src/main/java/org/springframework/security/web/context/HttpRequestResponseHolder.java

@@ -27,7 +27,9 @@
  *
  * @author Luke Taylor
  * @since 3.0
+ * @deprecated Use {@link SecurityContextRepository#loadContext(HttpServletRequest)}
  */
+@Deprecated
 public final class HttpRequestResponseHolder {
 
 	private HttpServletRequest request;

web/src/main/java/org/springframework/security/web/context/SaveContextOnUpdateOrErrorResponseWrapper.java

@@ -16,6 +16,7 @@
 
 package org.springframework.security.web.context;
 
+import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 
 import org.springframework.security.core.context.SecurityContext;
@@ -39,7 +40,10 @@
  * @author Marten Algesten
  * @author Rob Winch
  * @since 3.0
+ * @deprecated Use {@link SecurityContextRepository#loadContext(HttpServletRequest)}
+ * instead.
  */
+@Deprecated
 public abstract class SaveContextOnUpdateOrErrorResponseWrapper extends OnCommittedResponseWrapper {
 
 	private boolean contextSaved = false;

web/src/main/java/org/springframework/security/web/context/SecurityContextPersistenceFilter.java

@@ -57,7 +57,9 @@
  *
  * @author Luke Taylor
  * @since 3.0
+ * @deprecated Use {@link SecurityContextHolderFilter}
  */
+@Deprecated
 public class SecurityContextPersistenceFilter extends GenericFilterBean {
 
 	static final String FILTER_APPLIED = "__spring_security_scpf_applied";

web/src/main/java/org/springframework/security/web/context/SecurityContextRepository.java

@@ -60,7 +60,9 @@ public interface SecurityContextRepository {
 	 * the context should be loaded.
 	 * @return The security context which should be used for the current request, never
 	 * null.
+	 * @deprecated Use {@link #loadContext(HttpServletRequest)} instead.
 	 */
+	@Deprecated
 	SecurityContext loadContext(HttpRequestResponseHolder requestResponseHolder);
 
 	/**