Skip to content

Commit 3d1e4b5

Browse files
committed
Polish Tests
Confirm that responses are a valid JSON map Issue gh-16177
1 parent 96a9cf0 commit 3d1e4b5

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

config/src/test/java/org/springframework/security/config/web/server/OidcLogoutSpecTests.java

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
import org.springframework.context.annotation.Bean;
5151
import org.springframework.context.annotation.Configuration;
5252
import org.springframework.context.annotation.Import;
53+
import org.springframework.core.ParameterizedTypeReference;
5354
import org.springframework.core.annotation.Order;
5455
import org.springframework.http.ResponseCookie;
5556
import org.springframework.http.client.reactive.ClientHttpConnector;
@@ -97,6 +98,7 @@
9798
import org.springframework.web.server.adapter.WebHttpHandlerBuilder;
9899

99100
import static org.hamcrest.Matchers.containsString;
101+
import static org.hamcrest.Matchers.hasValue;
100102
import static org.mockito.ArgumentMatchers.any;
101103
import static org.mockito.BDDMockito.given;
102104
import static org.mockito.Mockito.atLeastOnce;
@@ -195,7 +197,10 @@ void logoutWhenInvalidLogoutTokenThenBadRequest() {
195197
.body(BodyInserters.fromFormData("logout_token", "invalid"))
196198
.exchange()
197199
.expectStatus()
198-
.isBadRequest();
200+
.isBadRequest()
201+
.expectBody(new ParameterizedTypeReference<Map<String, String>>() {
202+
})
203+
.value(hasValue("invalid_request"));
199204
this.test.get().uri("/token/logout").cookie("SESSION", session).exchange().expectStatus().isOk();
200205
}
201206

@@ -262,9 +267,10 @@ void logoutWhenRemoteLogoutUriThenUses() {
262267
.exchange()
263268
.expectStatus()
264269
.isBadRequest()
265-
.expectBody(String.class)
266-
.value(containsString("partial_logout"))
267-
.value(containsString("not all sessions were terminated"));
270+
.expectBody(new ParameterizedTypeReference<Map<String, String>>() {
271+
})
272+
.value(hasValue("partial_logout"))
273+
.value(hasValue(containsString("not all sessions were terminated")));
268274
this.test.get().uri("/token/logout").cookie("SESSION", one).exchange().expectStatus().isOk();
269275
}
270276

0 commit comments

Comments
 (0)