Skip to content

Commit 4f682f2

Browse files
Address SessionLimitStrategy
Closes gh-16206
1 parent 010496c commit 4f682f2

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

web/src/main/java/org/springframework/security/web/session/SessionLimitStrategy.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public interface SessionLimitStrategy extends Function<Authentication, Integer>
4242
* @return a {@link SessionLimitStrategy} instance that returns the given value.
4343
*/
4444
static SessionLimitStrategy of(int maxSessions) {
45-
Assert.isTrue(maxSessions != 0 && maxSessions >= -1,
45+
Assert.isTrue(maxSessions != 0,
4646
"MaximumLogins must be either -1 to allow unlimited logins, or a positive integer to specify a maximum");
4747
return (authentication) -> maxSessions;
4848
}

web/src/test/java/org/springframework/security/web/session/SessionLimitStrategyTests.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,24 +35,23 @@ class SessionLimitStrategyTests {
3535
private final Authentication authentication = Mockito.mock(Authentication.class);
3636

3737
@Test
38-
void testUnlimitedInstanceTest() {
38+
void testUnlimitedInstance() {
3939
SessionLimitStrategy sessionLimit = SessionLimitStrategy.UNLIMITED;
4040
int result = sessionLimit.apply(this.authentication);
4141
assertThat(result).isEqualTo(-1);
4242
}
4343

4444
@ParameterizedTest
4545
@ValueSource(ints = { -1, 1, 2, 3 })
46-
void testInstanceWithValidMaxSessionsTest(int maxSessions) {
46+
void testInstanceWithValidMaxSessions(int maxSessions) {
4747
SessionLimitStrategy sessionLimit = SessionLimitStrategy.of(maxSessions);
4848
int result = sessionLimit.apply(this.authentication);
4949
assertThat(result).isEqualTo(maxSessions);
5050
}
5151

52-
@ParameterizedTest
53-
@ValueSource(ints = { -4, -3, -2, 0 })
54-
void testInstanceWithInvalidMaxSessionsTest(int maxSessions) {
55-
assertThatIllegalArgumentException().isThrownBy(() -> SessionLimitStrategy.of(maxSessions))
52+
@Test
53+
void testInstanceWithInvalidMaxSessions() {
54+
assertThatIllegalArgumentException().isThrownBy(() -> SessionLimitStrategy.of(0))
5655
.withMessage(
5756
"MaximumLogins must be either -1 to allow unlimited logins, or a positive integer to specify a maximum");
5857
}

0 commit comments

Comments
 (0)