Skip to content

Commit 5af7c73

Browse files
committed
Change @bean method signature to return RsaKeyConversionServicePostProcessor instead of BeanFactoryPostProcessor
It's friendly for Spring Boot's `@ConditionalOnMissingBean`, and: >> When defining a Spring `@Bean` method, it is generally recommended to declare the most specific type possible as the method's return type. This means returning the concrete class of the bean, or the most specific interface that the bean implements and through which it will be referenced in the application. Signed-off-by: Yanming Zhou <[email protected]>
1 parent eeb383a commit 5af7c73

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

config/src/main/java/org/springframework/security/config/annotation/web/configuration/WebSecurityConfiguration.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
import org.springframework.beans.factory.ObjectProvider;
3434
import org.springframework.beans.factory.annotation.Autowired;
3535
import org.springframework.beans.factory.config.BeanDefinition;
36-
import org.springframework.beans.factory.config.BeanFactoryPostProcessor;
3736
import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
3837
import org.springframework.beans.factory.support.BeanDefinitionBuilder;
3938
import org.springframework.beans.factory.support.BeanDefinitionRegistry;
@@ -79,6 +78,7 @@
7978
*
8079
* @author Rob Winch
8180
* @author Keesun Baik
81+
* @author Yanming Zhou
8282
* @since 3.2
8383
* @see EnableWebSecurity
8484
* @see WebSecurity
@@ -190,7 +190,7 @@ void setWebSecurityCustomizers(List<WebSecurityCustomizer> webSecurityCustomizer
190190
}
191191

192192
@Bean
193-
public static BeanFactoryPostProcessor conversionServicePostProcessor() {
193+
public static RsaKeyConversionServicePostProcessor conversionServicePostProcessor() {
194194
return new RsaKeyConversionServicePostProcessor();
195195
}
196196

config/src/main/java/org/springframework/security/config/annotation/web/reactive/WebFluxSecurityConfiguration.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121

2222
import org.springframework.beans.factory.ObjectProvider;
2323
import org.springframework.beans.factory.annotation.Autowired;
24-
import org.springframework.beans.factory.config.BeanFactoryPostProcessor;
2524
import org.springframework.context.ApplicationContext;
2625
import org.springframework.context.annotation.Bean;
2726
import org.springframework.context.annotation.Configuration;
@@ -44,12 +43,13 @@
4443

4544
/**
4645
* @author Rob Winch
46+
* @author Yanming Zhou
4747
* @since 5.0
4848
*/
4949
@Configuration(proxyBeanMethods = false)
5050
class WebFluxSecurityConfiguration {
5151

52-
public static final int WEB_FILTER_CHAIN_FILTER_ORDER = 0 - 100;
52+
public static final int WEB_FILTER_CHAIN_FILTER_ORDER = -100;
5353

5454
private static final String BEAN_NAME_PREFIX = "org.springframework.security.config.annotation.web.reactive.WebFluxSecurityConfiguration.";
5555

@@ -100,7 +100,7 @@ CsrfRequestDataValueProcessor requestDataValueProcessor() {
100100
}
101101

102102
@Bean
103-
static BeanFactoryPostProcessor conversionServicePostProcessor() {
103+
static RsaKeyConversionServicePostProcessor conversionServicePostProcessor() {
104104
return new RsaKeyConversionServicePostProcessor();
105105
}
106106

0 commit comments

Comments
 (0)