Skip to content

Commit 5cf40ab

Browse files
committed
Migrate to JUnit 5
Issue gh-9467
2 parents ff47086 + f800d2c commit 5cf40ab

File tree

1,076 files changed

+4397
-4035
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

1,076 files changed

+4397
-4035
lines changed

acl/src/test/java/org/springframework/security/acls/AclFormattingUtilsTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
package org.springframework.security.acls;
1818

19-
import org.junit.Test;
19+
import org.junit.jupiter.api.Test;
2020

2121
import org.springframework.security.acls.domain.AclFormattingUtils;
2222
import org.springframework.security.acls.model.Permission;

acl/src/test/java/org/springframework/security/acls/AclPermissionCacheOptimizerTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import java.util.Collections;
2121
import java.util.List;
2222

23-
import org.junit.Test;
23+
import org.junit.jupiter.api.Test;
2424

2525
import org.springframework.security.acls.domain.ObjectIdentityImpl;
2626
import org.springframework.security.acls.model.AclService;

acl/src/test/java/org/springframework/security/acls/AclPermissionEvaluatorTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
import java.util.Locale;
2020

21-
import org.junit.Test;
21+
import org.junit.jupiter.api.Test;
2222

2323
import org.springframework.security.acls.model.Acl;
2424
import org.springframework.security.acls.model.AclService;

acl/src/test/java/org/springframework/security/acls/afterinvocation/AclEntryAfterInvocationCollectionFilteringProviderTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import java.util.Collections;
2222
import java.util.List;
2323

24-
import org.junit.Test;
24+
import org.junit.jupiter.api.Test;
2525

2626
import org.springframework.security.access.ConfigAttribute;
2727
import org.springframework.security.access.SecurityConfig;

acl/src/test/java/org/springframework/security/acls/afterinvocation/AclEntryAfterInvocationProviderTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import java.util.Collections;
2121
import java.util.List;
2222

23-
import org.junit.Test;
23+
import org.junit.jupiter.api.Test;
2424

2525
import org.springframework.security.access.AccessDeniedException;
2626
import org.springframework.security.access.ConfigAttribute;

acl/src/test/java/org/springframework/security/acls/domain/AccessControlImplEntryTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
package org.springframework.security.acls.domain;
1818

19-
import org.junit.Test;
19+
import org.junit.jupiter.api.Test;
2020

2121
import org.springframework.security.acls.model.AccessControlEntry;
2222
import org.springframework.security.acls.model.Acl;

acl/src/test/java/org/springframework/security/acls/domain/AclAuthorizationStrategyImplTests.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@
1818

1919
import java.util.Arrays;
2020

21-
import org.junit.After;
22-
import org.junit.Before;
23-
import org.junit.Test;
24-
import org.junit.runner.RunWith;
21+
import org.junit.jupiter.api.AfterEach;
22+
import org.junit.jupiter.api.BeforeEach;
23+
import org.junit.jupiter.api.Test;
24+
import org.junit.jupiter.api.extension.ExtendWith;
2525
import org.mockito.Mock;
26-
import org.mockito.junit.MockitoJUnitRunner;
26+
import org.mockito.junit.jupiter.MockitoExtension;
2727

2828
import org.springframework.security.acls.model.Acl;
2929
import org.springframework.security.authentication.TestingAuthenticationToken;
@@ -37,7 +37,7 @@
3737
* @author Rob Winch
3838
*
3939
*/
40-
@RunWith(MockitoJUnitRunner.class)
40+
@ExtendWith(MockitoExtension.class)
4141
public class AclAuthorizationStrategyImplTests {
4242

4343
@Mock
@@ -47,7 +47,7 @@ public class AclAuthorizationStrategyImplTests {
4747

4848
AclAuthorizationStrategyImpl strategy;
4949

50-
@Before
50+
@BeforeEach
5151
public void setup() {
5252
this.authority = new SimpleGrantedAuthority("ROLE_AUTH");
5353
TestingAuthenticationToken authentication = new TestingAuthenticationToken("foo", "bar",
@@ -56,7 +56,7 @@ public void setup() {
5656
SecurityContextHolder.getContext().setAuthentication(authentication);
5757
}
5858

59-
@After
59+
@AfterEach
6060
public void cleanup() {
6161
SecurityContextHolder.clearContext();
6262
}

acl/src/test/java/org/springframework/security/acls/domain/AclImplTests.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@
2222
import java.util.List;
2323
import java.util.Map;
2424

25-
import org.junit.After;
26-
import org.junit.Before;
27-
import org.junit.Test;
25+
import org.junit.jupiter.api.AfterEach;
26+
import org.junit.jupiter.api.BeforeEach;
27+
import org.junit.jupiter.api.Test;
2828

2929
import org.springframework.security.acls.model.AccessControlEntry;
3030
import org.springframework.security.acls.model.Acl;
@@ -83,7 +83,7 @@ public class AclImplTests {
8383

8484
private DefaultPermissionFactory permissionFactory;
8585

86-
@Before
86+
@BeforeEach
8787
public void setUp() {
8888
SecurityContextHolder.getContext().setAuthentication(this.auth);
8989
this.authzStrategy = mock(AclAuthorizationStrategy.class);
@@ -93,7 +93,7 @@ public void setUp() {
9393
this.permissionFactory = new DefaultPermissionFactory();
9494
}
9595

96-
@After
96+
@AfterEach
9797
public void tearDown() {
9898
SecurityContextHolder.clearContext();
9999
}

acl/src/test/java/org/springframework/security/acls/domain/AclImplementationSecurityCheckTests.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616

1717
package org.springframework.security.acls.domain;
1818

19-
import org.junit.After;
20-
import org.junit.Before;
21-
import org.junit.Test;
19+
import org.junit.jupiter.api.AfterEach;
20+
import org.junit.jupiter.api.BeforeEach;
21+
import org.junit.jupiter.api.Test;
2222

2323
import org.springframework.security.access.AccessDeniedException;
2424
import org.springframework.security.acls.model.Acl;
@@ -43,12 +43,12 @@ public class AclImplementationSecurityCheckTests {
4343

4444
private static final String TARGET_CLASS = "org.springframework.security.acls.TargetObject";
4545

46-
@Before
46+
@BeforeEach
4747
public void setUp() {
4848
SecurityContextHolder.clearContext();
4949
}
5050

51-
@After
51+
@AfterEach
5252
public void tearDown() {
5353
SecurityContextHolder.clearContext();
5454
}

acl/src/test/java/org/springframework/security/acls/domain/AuditLoggerTests.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@
1919
import java.io.ByteArrayOutputStream;
2020
import java.io.PrintStream;
2121

22-
import org.junit.After;
23-
import org.junit.Before;
24-
import org.junit.Test;
22+
import org.junit.jupiter.api.AfterEach;
23+
import org.junit.jupiter.api.BeforeEach;
24+
import org.junit.jupiter.api.Test;
2525

2626
import org.springframework.security.acls.model.AccessControlEntry;
2727
import org.springframework.security.acls.model.AuditableAccessControlEntry;
@@ -45,15 +45,15 @@ public class AuditLoggerTests {
4545

4646
private AuditableAccessControlEntry ace;
4747

48-
@Before
48+
@BeforeEach
4949
public void setUp() {
5050
this.logger = new ConsoleAuditLogger();
5151
this.ace = mock(AuditableAccessControlEntry.class);
5252
this.console = System.out;
5353
System.setOut(new PrintStream(this.bytes));
5454
}
5555

56-
@After
56+
@AfterEach
5757
public void tearDown() {
5858
System.setOut(this.console);
5959
this.bytes.reset();

0 commit comments

Comments
 (0)