Skip to content

Commit 719149f

Browse files
larsgrefermarcusdacoregio
authored andcommitted
Remove usages of Gradle's jcenter() repository
Closes gh-10253
1 parent ccd3060 commit 719149f

File tree

3 files changed

+6
-18
lines changed

3 files changed

+6
-18
lines changed

buildSrc/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ plugins {
99
sourceCompatibility = 1.8
1010

1111
repositories {
12-
jcenter()
1312
gradlePluginPortal()
1413
mavenCentral()
1514
maven { url 'https://repo.spring.io/plugins-release/' }

buildSrc/src/main/groovy/io/spring/gradle/convention/RepositoryConventionPlugin.groovy

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,6 @@ class RepositoryConventionPlugin implements Plugin<Project> {
3535
mavenLocal()
3636
}
3737
mavenCentral()
38-
jcenter() {
39-
content {
40-
includeGroup "org.gretty"
41-
}
42-
}
4338
if (isSnapshot) {
4439
maven {
4540
name = 'artifactory-snapshot'

buildSrc/src/test/java/io/spring/gradle/convention/RepositoryConventionPluginTests.java

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ public void applyWhenIsReleaseWithForceLocalThenShouldIncludeReleaseAndLocalRepo
107107
this.project.getPluginManager().apply(RepositoryConventionPlugin.class);
108108

109109
RepositoryHandler repositories = this.project.getRepositories();
110-
assertThat(repositories).hasSize(5);
110+
assertThat(repositories).hasSize(4);
111111
assertThat((repositories.get(0)).getName()).isEqualTo("MavenLocal");
112112
}
113113

@@ -119,39 +119,33 @@ public void applyWhenIsReleaseWithForceMilestoneAndLocalThenShouldIncludeMilesto
119119
this.project.getPluginManager().apply(RepositoryConventionPlugin.class);
120120

121121
RepositoryHandler repositories = this.project.getRepositories();
122-
assertThat(repositories).hasSize(6);
122+
assertThat(repositories).hasSize(5);
123123
assertThat((repositories.get(0)).getName()).isEqualTo("MavenLocal");
124124
}
125125

126126
private void assertSnapshotRepository(RepositoryHandler repositories) {
127-
assertThat(repositories).extracting(ArtifactRepository::getName).hasSize(6);
127+
assertThat(repositories).extracting(ArtifactRepository::getName).hasSize(5);
128128
assertThat(((MavenArtifactRepository) repositories.get(0)).getUrl().toString())
129129
.isEqualTo("https://repo.maven.apache.org/maven2/");
130130
assertThat(((MavenArtifactRepository) repositories.get(1)).getUrl().toString())
131-
.isEqualTo("https://jcenter.bintray.com/");
132-
assertThat(((MavenArtifactRepository) repositories.get(2)).getUrl().toString())
133131
.isEqualTo("https://repo.spring.io/snapshot/");
134-
assertThat(((MavenArtifactRepository) repositories.get(3)).getUrl().toString())
132+
assertThat(((MavenArtifactRepository) repositories.get(2)).getUrl().toString())
135133
.isEqualTo("https://repo.spring.io/milestone/");
136134
}
137135

138136
private void assertMilestoneRepository(RepositoryHandler repositories) {
139-
assertThat(repositories).extracting(ArtifactRepository::getName).hasSize(5);
137+
assertThat(repositories).extracting(ArtifactRepository::getName).hasSize(4);
140138
assertThat(((MavenArtifactRepository) repositories.get(0)).getUrl().toString())
141139
.isEqualTo("https://repo.maven.apache.org/maven2/");
142140
assertThat(((MavenArtifactRepository) repositories.get(1)).getUrl().toString())
143-
.isEqualTo("https://jcenter.bintray.com/");
144-
assertThat(((MavenArtifactRepository) repositories.get(2)).getUrl().toString())
145141
.isEqualTo("https://repo.spring.io/milestone/");
146142
}
147143

148144
private void assertReleaseRepository(RepositoryHandler repositories) {
149-
assertThat(repositories).extracting(ArtifactRepository::getName).hasSize(4);
145+
assertThat(repositories).extracting(ArtifactRepository::getName).hasSize(3);
150146
assertThat(((MavenArtifactRepository) repositories.get(0)).getUrl().toString())
151147
.isEqualTo("https://repo.maven.apache.org/maven2/");
152148
assertThat(((MavenArtifactRepository) repositories.get(1)).getUrl().toString())
153-
.isEqualTo("https://jcenter.bintray.com/");
154-
assertThat(((MavenArtifactRepository) repositories.get(2)).getUrl().toString())
155149
.isEqualTo("https://repo.spring.io/release/");
156150
}
157151

0 commit comments

Comments
 (0)