Use contains() instead of indexOf() != -1

larsgrefer · jzheaux · commit 7dc28ff3761c · 2019-07-09T06:07:42.000-06:00
diff --git a/core/src/test/java/org/springframework/security/core/userdetails/UserTests.java b/core/src/test/java/org/springframework/security/core/userdetails/UserTests.java
@@ -129,7 +129,7 @@ public void testUserGettersSetter() throws Exception {
 				"ROLE_ONE");
 		assertThat(AuthorityUtils.authorityListToSet(user.getAuthorities())).contains(
 				"ROLE_TWO");
-		assertThat(user.toString().indexOf("rod") != -1).isTrue();
+		assertThat(user.toString()).contains("rod");
 	}
 
 	@Test

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ public void testUserGettersSetter() throws Exception {`
`129`	`129`	`"ROLE_ONE");`
`130`	`130`	`assertThat(AuthorityUtils.authorityListToSet(user.getAuthorities())).contains(`
`131`	`131`	`"ROLE_TWO");`
`132`		`- assertThat(user.toString().indexOf("rod") != -1).isTrue();`
	`132`	`+ assertThat(user.toString()).contains("rod");`
`133`	`133`	`}`
`134`	`134`
`135`	`135`	`@Test`