Skip to content

Commit 919ae1d

Browse files
committed
Use PathPatternRequestMatcher in oauth2
Issue gh-16887
1 parent 7da3521 commit 919ae1d

11 files changed

+8
-17
lines changed

config/src/main/java/org/springframework/security/config/annotation/web/configurers/oauth2/client/OAuth2LoginConfigurer.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
import org.springframework.security.authentication.AuthenticationProvider;
3939
import org.springframework.security.config.Customizer;
4040
import org.springframework.security.config.annotation.web.HttpSecurityBuilder;
41-
import org.springframework.security.config.annotation.web.RequestMatcherFactory;
4241
import org.springframework.security.config.annotation.web.builders.HttpSecurity;
4342
import org.springframework.security.config.annotation.web.configurers.AbstractAuthenticationFilterConfigurer;
4443
import org.springframework.security.config.annotation.web.configurers.AbstractHttpConfigurer;
@@ -297,7 +296,7 @@ public OAuth2LoginConfigurer<B> userInfoEndpoint(Customizer<UserInfoEndpointConf
297296
public void init(B http) throws Exception {
298297
OAuth2LoginAuthenticationFilter authenticationFilter = new OAuth2LoginAuthenticationFilter(
299298
this.getClientRegistrationRepository(), this.getAuthorizedClientRepository(), this.loginProcessingUrl);
300-
RequestMatcher processUri = RequestMatcherFactory.matcher(this.loginProcessingUrl);
299+
RequestMatcher processUri = getRequestMatcherBuilder().matcher(this.loginProcessingUrl);
301300
authenticationFilter.setRequiresAuthenticationRequestMatcher(processUri);
302301
authenticationFilter.setSecurityContextHolderStrategy(getSecurityContextHolderStrategy());
303302
this.setAuthenticationFilter(authenticationFilter);
@@ -381,7 +380,7 @@ public void configure(B http) throws Exception {
381380
OAuth2LoginAuthenticationFilter authenticationFilter = this.getAuthenticationFilter();
382381
if (this.redirectionEndpointConfig.authorizationResponseBaseUri != null) {
383382
authenticationFilter.setRequiresAuthenticationRequestMatcher(
384-
RequestMatcherFactory.matcher(this.redirectionEndpointConfig.authorizationResponseBaseUri));
383+
getRequestMatcherBuilder().matcher(this.redirectionEndpointConfig.authorizationResponseBaseUri));
385384
}
386385
if (this.authorizationEndpointConfig.authorizationRequestRepository != null) {
387386
authenticationFilter
@@ -393,7 +392,7 @@ public void configure(B http) throws Exception {
393392

394393
@Override
395394
protected RequestMatcher createLoginProcessingUrlMatcher(String loginProcessingUrl) {
396-
return RequestMatcherFactory.matcher(loginProcessingUrl);
395+
return getRequestMatcherBuilder().matcher(loginProcessingUrl);
397396
}
398397

399398
private OAuth2AuthorizationRequestResolver getAuthorizationRequestResolver() {
@@ -531,8 +530,8 @@ private Map<String, String> getLoginLinks() {
531530
}
532531

533532
private AuthenticationEntryPoint getLoginEntryPoint(B http, String providerLoginPage) {
534-
RequestMatcher loginPageMatcher = RequestMatcherFactory.matcher(this.getLoginPage());
535-
RequestMatcher faviconMatcher = RequestMatcherFactory.matcher("/favicon.ico");
533+
RequestMatcher loginPageMatcher = getRequestMatcherBuilder().matcher(this.getLoginPage());
534+
RequestMatcher faviconMatcher = getRequestMatcherBuilder().matcher("/favicon.ico");
536535
RequestMatcher defaultEntryPointMatcher = this.getAuthenticationEntryPointMatcher(http);
537536
RequestMatcher defaultLoginPageMatcher = new AndRequestMatcher(
538537
new OrRequestMatcher(loginPageMatcher, faviconMatcher), defaultEntryPointMatcher);

config/src/test/resources/org/springframework/security/config/http/OAuth2ResourceServerBeanDefinitionParserTests-AuthenticationManagerResolver.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,5 +32,4 @@
3232
</http>
3333

3434
<b:import resource="userservice.xml"/>
35-
<b:import resource="handlermappingintrospector.xml"/>
3635
</b:beans>

config/src/test/resources/org/springframework/security/config/http/OAuth2ResourceServerBeanDefinitionParserTests-BasicAndResourceServer.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,5 +33,4 @@
3333
</http>
3434

3535
<b:import resource="userservice.xml"/>
36-
<b:import resource="handlermappingintrospector.xml"/>
3736
</b:beans>

config/src/test/resources/org/springframework/security/config/http/OAuth2ResourceServerBeanDefinitionParserTests-FormAndResourceServer.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,5 +33,4 @@
3333
</http>
3434

3535
<b:import resource="userservice.xml"/>
36-
<b:import resource="handlermappingintrospector.xml"/>
3736
</b:beans>

config/src/test/resources/org/springframework/security/config/http/OAuth2ResourceServerBeanDefinitionParserTests-JwkSetUri.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,4 @@
3939
</http>
4040

4141
<b:import resource="userservice.xml"/>
42-
<b:import resource="handlermappingintrospector.xml"/>
4342
</b:beans>

config/src/test/resources/org/springframework/security/config/http/OAuth2ResourceServerBeanDefinitionParserTests-Jwt.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,5 +32,4 @@
3232
</http>
3333

3434
<b:import resource="userservice.xml"/>
35-
<b:import resource="handlermappingintrospector.xml"/>
3635
</b:beans>

config/src/test/resources/org/springframework/security/config/http/OAuth2ResourceServerBeanDefinitionParserTests-JwtCustomSecurityContextHolderStrategy.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,5 +38,4 @@
3838
</b:bean>
3939

4040
<b:import resource="userservice.xml"/>
41-
<b:import resource="handlermappingintrospector.xml"/>
4241
</b:beans>

config/src/test/resources/org/springframework/security/config/http/OAuth2ResourceServerBeanDefinitionParserTests-MultipleIssuers.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,4 @@
3939
</http>
4040

4141
<b:import resource="userservice.xml"/>
42-
<b:import resource="handlermappingintrospector.xml"/>
4342
</b:beans>

config/src/test/resources/org/springframework/security/config/http/OAuth2ResourceServerBeanDefinitionParserTests-OpaqueToken.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,4 @@
3030
</http>
3131

3232
<b:import resource="userservice.xml"/>
33-
<b:import resource="handlermappingintrospector.xml"/>
3433
</b:beans>

config/src/test/resources/org/springframework/security/config/http/OAuth2ResourceServerBeanDefinitionParserTests-OpaqueTokenAndAuthenticationConverter.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,5 +34,4 @@
3434
</http>
3535

3636
<b:import resource="userservice.xml"/>
37-
<b:import resource="handlermappingintrospector.xml"/>
3837
</b:beans>

0 commit comments

Comments
 (0)