Skip to content

Commit 95ecc75

Browse files
committed
Improve serialVersionUID check in tests
Signed-off-by: johnycho <[email protected]>
1 parent 5a7d93e commit 95ecc75

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

config/src/test/java/org/springframework/security/SpringSecurityCoreVersionSerializableTests.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import java.util.Arrays;
3737
import java.util.HashSet;
3838
import java.util.List;
39+
import java.util.Objects;
3940
import java.util.Set;
4041
import java.util.stream.Stream;
4142

@@ -208,8 +209,8 @@ void allSerializableClassesShouldHaveSerialVersionOrSuppressWarnings() throws Ex
208209
.map(Field::getName)
209210
.anyMatch((n) -> n.equals("serialVersionUID"));
210211
SuppressWarnings suppressWarnings = clazz.getAnnotation(SuppressWarnings.class);
211-
boolean hasSerialIgnore = suppressWarnings == null
212-
|| Arrays.asList(suppressWarnings.value()).contains("Serial");
212+
boolean hasSerialIgnore = Objects.nonNull(suppressWarnings)
213+
&& Arrays.asList(suppressWarnings.value()).contains("serial");
213214
if (!hasSerialVersion && !hasSerialIgnore) {
214215
classes.add(clazz);
215216
continue;

0 commit comments

Comments
 (0)