Skip to content

Commit 9b12bce

Browse files
Revert "Address SessionLimitStrategy"
This reverts commit 67d40a1.
1 parent 03c42aa commit 9b12bce

File tree

56 files changed

+7
-167
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

56 files changed

+7
-167
lines changed

config/src/main/java/org/springframework/security/config/SecurityNamespaceHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ public BeanDefinition parse(Element element, ParserContext pc) {
9696
pc.getReaderContext()
9797
.fatal("You cannot use a spring-security-2.0.xsd or spring-security-3.0.xsd or "
9898
+ "spring-security-3.1.xsd schema or spring-security-3.2.xsd schema or spring-security-4.0.xsd schema "
99-
+ "with Spring Security 6.5. Please update your schema declarations to the 6.5 schema.",
99+
+ "with Spring Security 6.4. Please update your schema declarations to the 6.4 schema.",
100100
element);
101101
}
102102
String name = pc.getDelegate().getLocalName(element);
@@ -221,7 +221,7 @@ private boolean namespaceMatchesVersion(Element element) {
221221

222222
private boolean matchesVersionInternal(Element element) {
223223
String schemaLocation = element.getAttributeNS("http://www.w3.org/2001/XMLSchema-instance", "schemaLocation");
224-
return schemaLocation.matches("(?m).*spring-security-6\\.5.*.xsd.*")
224+
return schemaLocation.matches("(?m).*spring-security-6\\.4.*.xsd.*")
225225
|| schemaLocation.matches("(?m).*spring-security.xsd.*")
226226
|| !schemaLocation.matches("(?m).*spring-security.*");
227227
}

config/src/main/resources/META-INF/spring.schemas

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@
1414
# limitations under the License.
1515
#
1616

17-
http\://www.springframework.org/schema/security/spring-security.xsd=org/springframework/security/config/spring-security-6.5.xsd
18-
http\://www.springframework.org/schema/security/spring-security-6.5.xsd=org/springframework/security/config/spring-security-6.5.xsd
17+
http\://www.springframework.org/schema/security/spring-security.xsd=org/springframework/security/config/spring-security-6.4.xsd
1918
http\://www.springframework.org/schema/security/spring-security-6.4.xsd=org/springframework/security/config/spring-security-6.4.xsd
2019
http\://www.springframework.org/schema/security/spring-security-6.3.xsd=org/springframework/security/config/spring-security-6.3.xsd
2120
http\://www.springframework.org/schema/security/spring-security-6.2.xsd=org/springframework/security/config/spring-security-6.2.xsd
@@ -41,8 +40,7 @@ http\://www.springframework.org/schema/security/spring-security-2.0.xsd=org/spri
4140
http\://www.springframework.org/schema/security/spring-security-2.0.1.xsd=org/springframework/security/config/spring-security-2.0.1.xsd
4241
http\://www.springframework.org/schema/security/spring-security-2.0.2.xsd=org/springframework/security/config/spring-security-2.0.2.xsd
4342
http\://www.springframework.org/schema/security/spring-security-2.0.4.xsd=org/springframework/security/config/spring-security-2.0.4.xsd
44-
https\://www.springframework.org/schema/security/spring-security.xsd=org/springframework/security/config/spring-security-6.5.xsd
45-
https\://www.springframework.org/schema/security/spring-security-6.5.xsd=org/springframework/security/config/spring-security-6.5.xsd
43+
https\://www.springframework.org/schema/security/spring-security.xsd=org/springframework/security/config/spring-security-6.4.xsd
4644
https\://www.springframework.org/schema/security/spring-security-6.4.xsd=org/springframework/security/config/spring-security-6.4.xsd
4745
https\://www.springframework.org/schema/security/spring-security-6.3.xsd=org/springframework/security/config/spring-security-6.3.xsd
4846
https\://www.springframework.org/schema/security/spring-security-6.2.xsd=org/springframework/security/config/spring-security-6.2.xsd

config/src/test/java/org/springframework/security/config/http/HttpHeadersConfigTests.java

Lines changed: 0 additions & 77 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@
3434
import org.springframework.beans.factory.xml.XmlBeanDefinitionStoreException;
3535
import org.springframework.security.config.test.SpringTestContext;
3636
import org.springframework.security.config.test.SpringTestContextExtension;
37-
import org.springframework.security.core.Authentication;
38-
import org.springframework.security.web.session.SessionLimitStrategy;
3937
import org.springframework.test.web.servlet.MockMvc;
4038
import org.springframework.test.web.servlet.ResultMatcher;
4139
import org.springframework.test.web.servlet.request.MockHttpServletRequestBuilder;
@@ -842,69 +840,6 @@ public void requestWhenSessionManagementConcurrencyControlMaxSessionIsUnlimited(
842840
assertThat(firstSession.getId()).isNotEqualTo(secondSession.getId());
843841
}
844842

845-
@Test
846-
public void requestWhenSessionManagementConcurrencyControlMaxSessionRefIsOneForNonAdminUsers() throws Exception {
847-
this.spring.configLocations(this.xml("DefaultsSessionManagementConcurrencyControlMaxSessionsRef")).autowire();
848-
// @formatter:off
849-
MockHttpServletRequestBuilder requestBuilder = post("/login")
850-
.with(csrf())
851-
.param("username", "user")
852-
.param("password", "password");
853-
HttpSession firstSession = this.mvc.perform(requestBuilder)
854-
.andExpect(status().is3xxRedirection())
855-
.andExpect(redirectedUrl("/"))
856-
.andReturn()
857-
.getRequest()
858-
.getSession(false);
859-
// @formatter:on
860-
assertThat(firstSession).isNotNull();
861-
// @formatter:off
862-
this.mvc.perform(requestBuilder)
863-
.andExpect(status().isFound())
864-
.andExpect(redirectedUrl("/login?error"));
865-
// @formatter:on
866-
}
867-
868-
@Test
869-
public void requestWhenSessionManagementConcurrencyControlMaxSessionRefIsTwoForAdminUsers() throws Exception {
870-
this.spring.configLocations(this.xml("DefaultsSessionManagementConcurrencyControlMaxSessionsRef")).autowire();
871-
// @formatter:off
872-
MockHttpServletRequestBuilder requestBuilder = post("/login")
873-
.with(csrf())
874-
.param("username", "admin")
875-
.param("password", "password");
876-
HttpSession firstSession = this.mvc.perform(requestBuilder)
877-
.andExpect(status().is3xxRedirection())
878-
.andExpect(redirectedUrl("/"))
879-
.andReturn()
880-
.getRequest()
881-
.getSession(false);
882-
assertThat(firstSession).isNotNull();
883-
HttpSession secondSession = this.mvc.perform(requestBuilder)
884-
.andExpect(status().is3xxRedirection())
885-
.andExpect(redirectedUrl("/"))
886-
.andReturn()
887-
.getRequest()
888-
.getSession(false);
889-
assertThat(secondSession).isNotNull();
890-
// @formatter:on
891-
assertThat(firstSession.getId()).isNotEqualTo(secondSession.getId());
892-
// @formatter:off
893-
this.mvc.perform(requestBuilder)
894-
.andExpect(status().isFound())
895-
.andExpect(redirectedUrl("/login?error"));
896-
// @formatter:on
897-
}
898-
899-
@Test
900-
public void requestWhenSessionManagementConcurrencyControlWithInvalidMaxSessionConfig() {
901-
assertThatExceptionOfType(BeanDefinitionParsingException.class)
902-
.isThrownBy(() -> this.spring
903-
.configLocations(this.xml("DefaultsSessionManagementConcurrencyControlWithInvalidMaxSessionsConfig"))
904-
.autowire())
905-
.withMessageContaining("Cannot use 'max-sessions' attribute and 'max-sessions-ref' attribute together.");
906-
}
907-
908843
private static ResultMatcher includesDefaults() {
909844
return includes(defaultHeaders);
910845
}
@@ -955,16 +890,4 @@ public String ok() {
955890

956891
}
957892

958-
public static class CustomSessionLimit implements SessionLimitStrategy {
959-
960-
@Override
961-
public Integer apply(Authentication authentication) {
962-
if ("admin".equals(authentication.getName())) {
963-
return 2;
964-
}
965-
return 1;
966-
}
967-
968-
}
969-
970893
}

config/src/test/resources/org/springframework/security/config/http/HttpHeadersConfigTests-DefaultsSessionManagementConcurrencyControlMaxSessionsRef.xml

Lines changed: 0 additions & 40 deletions
This file was deleted.

config/src/test/resources/org/springframework/security/config/http/HttpHeadersConfigTests-DefaultsSessionManagementConcurrencyControlWithInvalidMaxSessionsConfig.xml

Lines changed: 0 additions & 41 deletions
This file was deleted.

config/src/test/resources/org/springframework/security/config/method-security.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
xmlns:tx="http://www.springframework.org/schema/tx"
2323
xsi:schemaLocation="http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans-3.0.xsd
2424
http://www.springframework.org/schema/tx https://www.springframework.org/schema/tx/spring-tx.xsd
25-
http://www.springframework.org/schema/security org/springframework/security/config/spring-security-6.5.xsd">
25+
http://www.springframework.org/schema/security org/springframework/security/config/spring-security-6.4.xsd">
2626

2727
<tx:annotation-driven />
2828

0 commit comments

Comments
 (0)