Cleanup

Author: justincranford

web/src/main/java/org/springframework/security/web/webauthn/api/AuthenticatorTransport.java

@@ -23,6 +23,7 @@
  * order to obtain an assertion for a specific credential.
  *
  * @author Rob Winch
+ * @author Justin Cranford
  * @since 6.4
  */
 public final class AuthenticatorTransport {

web/src/main/java/org/springframework/security/web/webauthn/api/COSEAlgorithmIdentifier.java

@@ -22,6 +22,7 @@
  * used to identify a cryptographic algorithm.
  *
  * @author Rob Winch
+ * @author Justin Cranford
  * @since 6.4
  * @see PublicKeyCredentialParameters#getAlg()
  */

web/src/main/java/org/springframework/security/web/webauthn/api/PublicKeyCredentialParameters.java

@@ -22,6 +22,7 @@
  * is used to supply additional parameters when creating a new credential.
  *
  * @author Rob Winch
+ * @author Justin Cranford
  * @since 6.4
  * @see PublicKeyCredentialCreationOptions#getPubKeyCredParams()
  */

web/src/main/java/org/springframework/security/web/webauthn/jackson/AuthenticatorSelectionCriteriaDeserializer.java

@@ -31,9 +31,8 @@
 /**
  * Jackson deserializer for {@link AuthenticatorSelectionCriteria}
  *
- * @author Rob Winch
  * @author Justin Cranford
- * @since 6.4
+ * @since 6.5
  */
 @SuppressWarnings("serial")
 class AuthenticatorSelectionCriteriaDeserializer extends StdDeserializer<AuthenticatorSelectionCriteria> {

web/src/main/java/org/springframework/security/web/webauthn/jackson/AuthenticatorSelectionCriteriaSerializer.java

@@ -26,9 +26,8 @@
 /**
  * Jackson serializer for {@link AuthenticatorSelectionCriteria}
  *
- * @author Rob Winch
  * @author Justin Cranford
- * @since 6.4
+ * @since 6.5
  */
 @SuppressWarnings("serial")
 class AuthenticatorSelectionCriteriaSerializer extends StdSerializer<AuthenticatorSelectionCriteria> {

web/src/main/java/org/springframework/security/web/webauthn/jackson/PublicKeyCredentialTypeMixin.java

@@ -25,6 +25,7 @@
  * Jackson mixin for {@link PublicKeyCredentialType}
  *
  * @author Rob Winch
+ * @author Justin Cranford
  * @since 6.4
  */
 abstract class PublicKeyCredentialTypeMixin {

web/src/main/java/org/springframework/security/web/webauthn/jackson/ResidentKeyRequirementMixin.java

@@ -23,8 +23,9 @@
 /**
  * Jackson mixin for {@link ResidentKeyRequirement}
  *
+ * @author Rob Winch
  * @author Justin Cranford
- * @since 6.5
+ * @since 6.4
  */
 @JsonSerialize(using = ResidentKeyRequirementSerializer.class)
 @JsonDeserialize(using = ResidentKeyRequirementDeserializer.class)

web/src/test/java/org/springframework/security/web/webauthn/jackson/JacksonTests.java

@@ -53,7 +53,6 @@ class JacksonTests {
 	void setup() {
 		this.mapper = new ObjectMapper();
 		this.mapper.registerModule(new WebauthnJackson2Module());
-		this.mapper.registerModule(new WebauthnJackson2Module());
 		this.mapper.registerModule(new JavaTimeModule());
 	}
 

web/src/test/java/org/springframework/security/web/webauthn/jackson/MinPinLengthAuthenticationExtensionsClientInput.java

@@ -1,10 +1,23 @@
+/*
+ * Copyright 2002-2024 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 package org.springframework.security.web.webauthn.jackson;
 
 import org.springframework.security.web.webauthn.api.AuthenticationExtensionsClientInput;
 
-// ImmutableAuthenticationExtensionsClientInputs wraps a List<AuthenticationExtensionsClientInput<T>>.
-// Since only CredProtectAuthenticationExtensionsClientInput implements AuthenticationExtensionsClientInput<T>,
-// a second class is needed to help test with two extensions.
 /**
  * Implements <a href=
  * "https://fidoalliance.org/specs/fido-v2.2-rd-20230321/fido-client-to-authenticator-protocol-v2.2-rd-20230321.html#sctn-minpinlength-extension">