Skip to content

Commit a2dc621

Browse files
Add Serializable for RelyingPartyRegistration
1 parent a5b0304 commit a2dc621

File tree

4 files changed

+17
-5
lines changed

4 files changed

+17
-5
lines changed

config/src/test/java/org/springframework/security/SpringSecurityCoreVersionSerializableTests.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,8 @@
123123
import org.springframework.security.saml2.provider.service.authentication.TestSaml2Authentications;
124124
import org.springframework.security.saml2.provider.service.authentication.TestSaml2PostAuthenticationRequests;
125125
import org.springframework.security.saml2.provider.service.authentication.TestSaml2RedirectAuthenticationRequests;
126+
import org.springframework.security.saml2.provider.service.registration.RelyingPartyRegistration;
127+
import org.springframework.security.saml2.provider.service.registration.TestRelyingPartyRegistrations;
126128
import org.springframework.security.web.authentication.WebAuthenticationDetails;
127129
import org.springframework.security.web.authentication.preauth.PreAuthenticatedAuthenticationToken;
128130

@@ -309,6 +311,7 @@ class SpringSecurityCoreVersionSerializableTests {
309311
(r) -> TestSaml2PostAuthenticationRequests.create());
310312
generatorByClassName.put(Saml2RedirectAuthenticationRequest.class,
311313
(r) -> TestSaml2RedirectAuthenticationRequests.create());
314+
generatorByClassName.put(RelyingPartyRegistration.class, (r) -> TestRelyingPartyRegistrations.full().build());
312315

313316
// web
314317
generatorByClassName.put(AnonymousAuthenticationToken.class, (r) -> {

saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/core/Saml2X509Credential.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2020 the original author or authors.
2+
* Copyright 2002-2024 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -16,13 +16,15 @@
1616

1717
package org.springframework.security.saml2.core;
1818

19+
import java.io.Serializable;
1920
import java.security.PrivateKey;
2021
import java.security.cert.X509Certificate;
2122
import java.util.Arrays;
2223
import java.util.LinkedHashSet;
2324
import java.util.Objects;
2425
import java.util.Set;
2526

27+
import org.springframework.security.core.SpringSecurityCoreVersion;
2628
import org.springframework.util.Assert;
2729

2830
/**
@@ -35,7 +37,9 @@
3537
* @author Josh Cummings
3638
* @since 5.4
3739
*/
38-
public final class Saml2X509Credential {
40+
public final class Saml2X509Credential implements Serializable {
41+
42+
private static final long serialVersionUID = SpringSecurityCoreVersion.SERIAL_VERSION_UID;
3943

4044
private final PrivateKey privateKey;
4145

saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/registration/AssertingPartyMetadata.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package org.springframework.security.saml2.provider.service.registration;
1818

19+
import java.io.Serializable;
1920
import java.util.Collection;
2021
import java.util.List;
2122
import java.util.function.Consumer;
@@ -28,7 +29,7 @@
2829
* @author Josh Cummings
2930
* @since 6.4
3031
*/
31-
public interface AssertingPartyMetadata {
32+
public interface AssertingPartyMetadata extends Serializable {
3233

3334
/**
3435
* Get the asserting party's <a href=

saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/registration/RelyingPartyRegistration.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2023 the original author or authors.
2+
* Copyright 2002-2024 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -16,6 +16,7 @@
1616

1717
package org.springframework.security.saml2.provider.service.registration;
1818

19+
import java.io.Serializable;
1920
import java.util.ArrayList;
2021
import java.util.Collection;
2122
import java.util.Collections;
@@ -24,6 +25,7 @@
2425
import java.util.List;
2526
import java.util.function.Consumer;
2627

28+
import org.springframework.security.core.SpringSecurityCoreVersion;
2729
import org.springframework.security.saml2.core.Saml2X509Credential;
2830
import org.springframework.util.Assert;
2931
import org.springframework.util.CollectionUtils;
@@ -66,7 +68,9 @@
6668
* @author Josh Cummings
6769
* @since 5.2
6870
*/
69-
public class RelyingPartyRegistration {
71+
public class RelyingPartyRegistration implements Serializable {
72+
73+
private static final long serialVersionUID = SpringSecurityCoreVersion.SERIAL_VERSION_UID;
7074

7175
private final String registrationId;
7276

0 commit comments

Comments
 (0)