Skip to content

Commit ca095db

Browse files
committed
Change @bean method signature to return RsaKeyConversionServicePostProcessor instead of BeanFactoryPostProcessor
It's friendly for Spring Boot's `@ConditionalOnMissingBean`, and: >> When defining a Spring `@Bean` method, it is generally recommended to declare the most specific type possible as the method's return type. This means returning the concrete class of the bean, or the most specific interface that the bean implements and through which it will be referenced in the application. Signed-off-by: Yanming Zhou <[email protected]>
1 parent eeb383a commit ca095db

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

config/src/main/java/org/springframework/security/config/annotation/web/configuration/WebSecurityConfiguration.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@
7979
*
8080
* @author Rob Winch
8181
* @author Keesun Baik
82+
* @author Yanming Zhou
8283
* @since 3.2
8384
* @see EnableWebSecurity
8485
* @see WebSecurity
@@ -190,7 +191,7 @@ void setWebSecurityCustomizers(List<WebSecurityCustomizer> webSecurityCustomizer
190191
}
191192

192193
@Bean
193-
public static BeanFactoryPostProcessor conversionServicePostProcessor() {
194+
public static RsaKeyConversionServicePostProcessor conversionServicePostProcessor() {
194195
return new RsaKeyConversionServicePostProcessor();
195196
}
196197

config/src/main/java/org/springframework/security/config/annotation/web/reactive/WebFluxSecurityConfiguration.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,13 @@
4444

4545
/**
4646
* @author Rob Winch
47+
* @author Yanming Zhou
4748
* @since 5.0
4849
*/
4950
@Configuration(proxyBeanMethods = false)
5051
class WebFluxSecurityConfiguration {
5152

52-
public static final int WEB_FILTER_CHAIN_FILTER_ORDER = 0 - 100;
53+
public static final int WEB_FILTER_CHAIN_FILTER_ORDER = -100;
5354

5455
private static final String BEAN_NAME_PREFIX = "org.springframework.security.config.annotation.web.reactive.WebFluxSecurityConfiguration.";
5556

@@ -100,7 +101,7 @@ CsrfRequestDataValueProcessor requestDataValueProcessor() {
100101
}
101102

102103
@Bean
103-
static BeanFactoryPostProcessor conversionServicePostProcessor() {
104+
static RsaKeyConversionServicePostProcessor conversionServicePostProcessor() {
104105
return new RsaKeyConversionServicePostProcessor();
105106
}
106107

0 commit comments

Comments
 (0)